Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: mojo/shell/identity.h

Issue 1307273004: Group ConnectToApplication-related info into a params struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/identity.h
diff --git a/mojo/shell/identity.h b/mojo/shell/identity.h
index 1aca15856184659c87034d5837ac159541d4409f..865d65284a22f112bf51297fa011025cb83d5cca 100644
--- a/mojo/shell/identity.h
+++ b/mojo/shell/identity.h
@@ -11,18 +11,23 @@ namespace mojo {
namespace shell {
/**
- * Represents the identity of an application. |url| is the url of the
+ * Represents the identity of an application. |url| is the URL of the
* application. |qualifier| is a string that allows to tie a specific instance
- * of an application to another. It is used by content handlers that need to be
- * run in the context of another application.
+ * of an application to another. A typical use case of qualifier is to control
Ben Goodger (Google) 2015/09/02 22:20:33 nit: C++ comments since you're changing the commen
yzshen1 2015/09/03 00:06:39 Done.
+ * process grouping for a given application URL. For example, the core services
+ * are grouped into "Core"/"Files"/"Network"/etc. using qualifier; content
+ * handler's qualifier is derived from the origin of the content.
*/
struct Identity {
+ Identity();
Identity(const GURL& in_url, const std::string& in_qualifier);
explicit Identity(const GURL& in_url);
+
bool operator<(const Identity& other) const;
+ bool is_null() const { return url.is_empty(); }
- const GURL url;
- const std::string qualifier;
+ GURL url;
+ std::string qualifier;
};
} // namespace shell

Powered by Google App Engine
This is Rietveld 408576698