|
Group ConnectToApplication-related info into a params struct.
It makes the code easier to read and less error-prone.
Besides, this CL also:
- stops using raw ApplicationInstance pointer to refer to originator, because it becomes invalid after the originator is gone.
- removes requestor_url because orignator_identity.url serves the same purpose.
BUG=None
Committed: https://crrev.com/be2a3831785d9ad205e542ca6e9ccb52f734307f
Cr-Commit-Position: refs/heads/master@{#347213}
Total comments: 2
Total comments: 9
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+478 lines, -360 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
content/browser/mojo/mojo_shell_context.cc
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+13 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/mojo_shell.gyp
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/runner/context.cc
|
View
|
1
2
3
4
|
2 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/BUILD.gn
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/application_instance.h
|
View
|
1
2
|
4 chunks |
+6 lines, -29 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/application_instance.cc
|
View
|
1
2
3
4
|
7 chunks |
+44 lines, -69 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/application_manager.h
|
View
|
1
2
3
4
|
7 chunks |
+23 lines, -46 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/application_manager.cc
|
View
|
1
2
3
4
|
13 chunks |
+103 lines, -129 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/application_manager_unittest.cc
|
View
|
1
2
3
4
|
7 chunks |
+63 lines, -55 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/capability_filter.h
|
View
|
1
|
2 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/capability_filter.cc
|
View
|
1
|
2 chunks |
+18 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A |
mojo/shell/connect_to_application_params.h
|
View
|
1
2
3
|
1 chunk |
+114 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A |
mojo/shell/connect_to_application_params.cc
|
View
|
1
2
3
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/content_handler_connection.h
|
View
|
1
2
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/content_handler_connection.cc
|
View
|
1
2
|
2 chunks |
+16 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/identity.h
|
View
|
1
2
3
4
|
1 chunk |
+12 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/shell/identity.cc
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 14 (3 generated)
|