Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 1307233006: Make previousBoundary() not to use Range object (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make previousBoundary() not to use Range object This patch changes |previousBoundary()| to use |Position::afterNode()| instead of |Range| object to avoid registering temporary |Range| object to |Document| and as a preparation of |previousBoundary()| to work on composed tree by templatization. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=388681, 513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201708

Patch Set 1 : 2015-09-03T14:46:53 #

Patch Set 2 : 2015-09-03T15:34:51 Remove redundant #include ExceptionState.h" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M Source/core/editing/VisibleUnits.cpp View 1 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-03 06:10:13 UTC) #2
tkent
rs-lgtm
5 years, 3 months ago (2015-09-03 06:14:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307233006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307233006/20001
5 years, 3 months ago (2015-09-03 06:35:39 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 07:44:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201708

Powered by Google App Engine
This is Rietveld 408576698