Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1307223009: tools/gn: Remove fallback to direct_dependent_configs. (Closed)

Created:
5 years, 3 months ago by tfarina
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: Remove fallback to direct_dependent_configs. If public_configs were undefined we would fallback to direct_dependent_configs. we can remove this now, since we converted all the projects to public_configs already. BUG=None R=brettw@chromium.org Committed: https://crrev.com/5591967b16af40155e7feb77efd6410b6c94a4ef Cr-Commit-Position: refs/heads/master@{#346769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M tools/gn/target_generator.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 3 months ago (2015-09-01 22:00:58 UTC) #1
brettw
lgtm
5 years, 3 months ago (2015-09-01 22:09:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307223009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307223009/1
5 years, 3 months ago (2015-09-01 22:54:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 23:01:06 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 23:02:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5591967b16af40155e7feb77efd6410b6c94a4ef
Cr-Commit-Position: refs/heads/master@{#346769}

Powered by Google App Engine
This is Rietveld 408576698