Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307223003: Remove pixelSnappedIntRect from BoxPainter::boundsForDrawingRecorder. (Closed)

Created:
5 years, 4 months ago by jbroman
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove pixelSnappedIntRect from BoxPainter::boundsForDrawingRecorder. BUG=525702 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201342

Patch Set 1 #

Patch Set 2 : request Mac rebaseline of fast/forms/color/input-appearance-color.html #

Patch Set 3 : a wild layout test appears #

Patch Set 4 : finishJSTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/subpixel-shadow-included-in-invalidation.html View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/subpixel-shadow-included-in-invalidation-expected.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
When combined with https://codereview.chromium.org/1308033003/, the layout test added by this CL passes. Still, the changes ...
5 years, 3 months ago (2015-08-27 19:45:03 UTC) #2
chrishtr
lgtm
5 years, 3 months ago (2015-08-27 22:19:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307223003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307223003/60001
5 years, 3 months ago (2015-08-27 22:19:41 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 22:24:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201342

Powered by Google App Engine
This is Rietveld 408576698