[es6] fix nested object literals with computed property names

src/ast.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_AST_H_
 #define V8_AST_H_
 
 #include "src/assembler.h"
 #include "src/ast-value-factory.h"
 #include "src/bailout-reason.h"
@@ skipping 1471 matching lines @@
 
   BailoutId CreateLiteralId() const { return BailoutId(local_id(0)); }
 
   // Return an AST id for a property that is used in simulate instructions.
   BailoutId GetIdForProperty(int i) { return BailoutId(local_id(i + 1)); }
 
   // Unlike other AST nodes, this number of bailout IDs allocated for an
   // ObjectLiteral can vary, so num_ids() is not a static method.
   int num_ids() const { return parent_num_ids() + 1 + properties()->length(); }
 
+  bool has_computed_property_names() const {
+    return boilerplate_properties_ == 0 && properties_->length() > 0;

[adamk, 2015/08/24 18:00:53]

I don't think the LHS of this expression is correct: it only works for object
literals whose first property has a computed name. See the way the
number_of_boilerplate_properties is accumulated in ParseObjectLiteral(): it only
stops counting up after it hits the first computed name. I suspect test cases
where the first property is non-computed will keep failing with this patch.

[adamk, 2015/08/24 18:14:29]

Hmm, local testing suggests I'm wrong about this failing, so I'm not totally
sure what's going on.

[adamk, 2015/08/24 18:16:37]

Sorry for the noise, I've confirmed that this is exactly the behavior (forgot to
negate the is_simple check so everything was getting marked non-simple).

+  }
+
   // Object literals need one feedback slot for each non-trivial value, as well
   // as some slots for home objects.
   FeedbackVectorRequirements ComputeFeedbackRequirements(
       Isolate* isolate, const ICSlotCache* cache) override;
   void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot,
                               ICSlotCache* cache) override {
     slot_ = slot;
   }
   Code::Kind FeedbackICSlotKind(int index) override { return Code::STORE_IC; }
   FeedbackVectorICSlot GetNthSlot(int n) const {
@@ skipping 2133 matching lines @@
 
  private:
   Zone* zone_;
   AstValueFactory* ast_value_factory_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_AST_H_