Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1307203005: [turbofan] Do not force stack slot for eager deopt inputs. (Closed)

Created:
5 years, 3 months ago by Jarin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Mircea Trofin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do not force stack slot for eager deopt inputs. R=bmeurer@chromium.org Committed: https://crrev.com/6893da537769a28806d99c195b710b9ad8c4280d Cr-Commit-Position: refs/heads/master@{#30565}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Tweak #

Patch Set 3 : Quest for gcc happiness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M src/compiler/instruction-selector.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 5 chunks +23 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Benedikt, could you take a look, please?
5 years, 3 months ago (2015-09-03 13:06:03 UTC) #2
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/1307203005/diff/1/src/compiler/instruction-selector.cc File src/compiler/instruction-selector.cc (right): https://codereview.chromium.org/1307203005/diff/1/src/compiler/instruction-selector.cc#newcode1077 src/compiler/instruction-selector.cc:1077: } Nit: Add UNREACHABLE() at the ...
5 years, 3 months ago (2015-09-03 13:11:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203005/40001
5 years, 3 months ago (2015-09-03 13:53:29 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-03 14:06:28 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 14:06:37 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6893da537769a28806d99c195b710b9ad8c4280d
Cr-Commit-Position: refs/heads/master@{#30565}

Powered by Google App Engine
This is Rietveld 408576698