C API: Add SK_API, also documentation of an example.

C API: Add SK_API, also documentation of an example.

SK_API = __declspec(dllexport) / __attribute__((visibility("default")))

Also, add documentation in experimental/c-api-example/c.md

Committed: https://skia.googlesource.com/skia/+/219f18f30df465beeee8114febe52fa50454a804

[hal.canary, 2015-09-01 15:40:52]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-09-01 15:40:52]

PTAL

[reed1, 2015-09-01 15:46:53]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-09-01 15:46:54]

lgtm

[mtklein, 2015-09-01 15:48:20]

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/c.md
File site/user/api/c.md (right):

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/c.md#newc...
site/user/api/c.md:1: Skia's Stable C API
Let's move this out of site/

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
File site/user/api/skia-c-example.c (right):

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
site/user/api/skia-c-example.c:37: (void)ret;
?

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
site/user/api/skia-c-example.c:44: sk_paint_t* paint = sk_paint_new();
might want to call this 'fill' so it's got better contrast with stroke?

[reed1, 2015-09-01 15:50:27]

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
File site/user/api/skia-c-example.c (right):

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
site/user/api/skia-c-example.c:44: sk_paint_t* paint = sk_paint_new();
Why do we assert on this allocation? (and not all paint allocs). I think the
assert is not needed.

[hal.canary, 2015-09-01 16:13:57]

done

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/c.md
File site/user/api/c.md (right):

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/c.md#newc...
site/user/api/c.md:1: Skia's Stable C API
On 2015/09/01 15:48:20, mtklein wrote:
> Let's move this out of site/

Done.

Moved to experimantal/c-example

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
File site/user/api/skia-c-example.c (right):

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
site/user/api/skia-c-example.c:37: (void)ret;
On 2015/09/01 15:48:20, mtklein wrote:
> ?

It was for -DNDEBUG=1 -Wunused-variable.  Removed

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
site/user/api/skia-c-example.c:44: sk_paint_t* paint = sk_paint_new();
On 2015/09/01 15:48:20, mtklein wrote:
> might want to call this 'fill' so it's got better contrast with stroke?

Done.

https://codereview.chromium.org/1307183006/diff/20001/site/user/api/skia-c-ex...
site/user/api/skia-c-example.c:44: sk_paint_t* paint = sk_paint_new();
On 2015/09/01 15:50:27, reed1 wrote:
> Why do we assert on this allocation? (and not all paint allocs). I think the
> assert is not needed.

Done.

[mtklein, 2015-09-01 16:30:35]

lgtm

[hal.canary, 2015-09-01 16:33:39]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-09-01 16:33:40]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1307183006/#ps40001
(title: "2015-09-01 (Tuesday) 12:13:34 EDT")

[commit-bot: I haz the power, 2015-09-01 16:33:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307183006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307183006/40001

[commit-bot: I haz the power, 2015-09-01 16:35:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 16:35:03]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[hal.canary, 2015-09-01 16:56:29]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-09-01 16:56:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1307183006/#ps60001
(title: "2015-09-01 (Tuesday) 12:56:15 EDT")

[commit-bot: I haz the power, 2015-09-01 16:56:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307183006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307183006/60001

[commit-bot: I haz the power, 2015-09-01 17:01:43]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/219f18f30df465beeee8114febe52fa50454a804