Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 1307143005: Make 2D canvas smarter about chosing whether or not to use GPU acceleration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 1307143005: Make 2D canvas smarter about chosing whether or not to use GPU acceleration (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fixing some logic Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp ('k') | Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | Source/platform/graphics/Canvas2DLayerBridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index f72be87889ef8d03528d474c29b592bbdd3859fd..17d00169d88d08364b587513b3a84e413437d09c 100644

--- a/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -646,7 +646,7 @@ void WebGL2RenderingContextBase::texSubImage3D(GLenum target, GLint level, GLint

if (!canvas->renderingContext() || !canvas->renderingContext()->isAccelerated()) {

ASSERT(!canvas->renderingContext() || canvas->renderingContext()->is2d());

// 2D canvas has only FrontBuffer.

- texSubImage3DImpl(target, level, xoffset, yoffset, zoffset, format, type, canvas->copiedImage(FrontBuffer).get(),

+ texSubImage3DImpl(target, level, xoffset, yoffset, zoffset, format, type, canvas->copiedImage(FrontBuffer, PreferAcceleration).get(),

WebGLImageConversion::HtmlDomCanvas, m_unpackFlipY, m_unpackPremultiplyAlpha);

return;

}