third_party/WebKit/Source/core/html/HTMLVideoElement.cpp - Issue 1307143005: Make 2D canvas smarter about chosing whether or not to use GPU acceleration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 1307143005: Make 2D canvas smarter about chosing whether or not to use GPU acceleration (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: migrated to chromium repo Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLImageElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLVideoElement.h ('k') | third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

index e64a10fd0aa63fa70bd7c1a0daedc0f29a5d553a..fe5170644016ab7a1e42efe73e22ff1a051996b1 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

@@ -284,7 +284,7 @@ KURL HTMLVideoElement::posterImageURL() const

return document().completeURL(url);

}

-PassRefPtr<Image> HTMLVideoElement::getSourceImageForCanvas(SourceImageStatus* status) const

+PassRefPtr<Image> HTMLVideoElement::getSourceImageForCanvas(SourceImageStatus* status, AccelerationHint) const

{

if (!hasAvailableVideoFrame()) {

*status = InvalidSourceImageStatus;

@@ -292,6 +292,7 @@ PassRefPtr<Image> HTMLVideoElement::getSourceImageForCanvas(SourceImageStatus* s

}

IntSize intrinsicSize(videoWidth(), videoHeight());

+ // FIXME: Not sure if we dhould we be doing anything with the AccelerationHint argument here?

OwnPtr<ImageBuffer> imageBuffer = ImageBuffer::create(intrinsicSize);

if (!imageBuffer) {

*status = InvalidSourceImageStatus;