Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 1307143004: Make navigation notification operation Source based, without Dart knowledge. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index 5dd9feb36d3ad3edcf75194702f2b0764fdeedd8..6b2c3775fe6da06d2422b4e5c0796b88d99d56aa 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -14,7 +14,7 @@ import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/context_manager.dart';
import 'package:analysis_server/src/domains/analysis/navigation.dart';
import 'package:analysis_server/src/operation/operation_analysis.dart'
- show sendAnalysisNotificationNavigation;
+ show NavigationOperation, sendAnalysisNotificationNavigation;
import 'package:analysis_server/src/protocol_server.dart';
import 'package:analysis_server/src/services/dependencies/library_dependencies.dart';
import 'package:analyzer/file_system/file_system.dart';
@@ -347,11 +347,10 @@ class AnalysisDomainImpl implements AnalysisDomain {
@override
void scheduleNotification(
engine.AnalysisContext context, Source source, AnalysisService service) {
- // TODO(scheglov) schedule, don't do it right now
String file = source.fullName;
if (server.hasAnalysisSubscription(service, file)) {
if (service == AnalysisService.NAVIGATION) {
- sendAnalysisNotificationNavigation(server, context, source);
+ server.scheduleOperation(new NavigationOperation(context, source));
}
}
}
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/lib/src/operation/operation_analysis.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698