Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.h

Issue 1307133003: ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.h
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.h b/content/browser/service_worker/service_worker_dispatcher_host.h
index 81dac6e5759ca863436157c10104e520ed8bc6a4..7a914029bb4a20f77b146623892bdf0aee1898e2 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.h
+++ b/content/browser/service_worker/service_worker_dispatcher_host.h
@@ -64,9 +64,8 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {
ServiceWorkerHandle* FindServiceWorkerHandle(int provider_id,
int64 version_id);
- // Returns the existing registration handle whose reference count is
- // incremented or newly created one if it doesn't exist.
- ServiceWorkerRegistrationHandle* GetOrCreateRegistrationHandle(
+ // Creates a new registration handle and registers it.
+ ServiceWorkerRegistrationHandle* CreateRegistrationHandle(
base::WeakPtr<ServiceWorkerProviderHost> provider_host,
ServiceWorkerRegistration* registration);
@@ -136,10 +135,6 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {
void OnServiceWorkerObjectDestroyed(int handle_id);
void OnTerminateWorker(int handle_id);
- ServiceWorkerRegistrationHandle* FindRegistrationHandle(
- int provider_id,
- int64 registration_id);
-
void GetRegistrationObjectInfoAndVersionAttributes(
base::WeakPtr<ServiceWorkerProviderHost> provider_host,
ServiceWorkerRegistration* registration,

Powered by Google App Engine
This is Rietveld 408576698