Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1307103004: Fixing WKWebView QuickBack (Closed)

Created:
5 years, 3 months ago by bhnascar
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing WKWebView QuickBack This patch changes a DCHECK used to validate WKBackForwardListItems before using them to an if check. This fixes a crash caused by QuickBack. BUG=529890 Committed: https://crrev.com/03f902257334935fa479fbc0e5fef241b0a6dd1f Cr-Commit-Position: refs/heads/master@{#348746}

Patch Set 1 #

Patch Set 2 : Revised fix #

Total comments: 1

Patch Set 3 : Fixing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 1 2 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (3 generated)
bhnascar
5 years, 3 months ago (2015-09-09 23:29:42 UTC) #2
Eugene But (OOO till 7-30)
It is unclear why BFLI is alive. If it's because Preload maintains 2 web views, ...
5 years, 3 months ago (2015-09-14 17:21:57 UTC) #3
kkhorimoto
The prerender controller creates a separate tab with its own WebState for omnibox autocomplete suggestions, ...
5 years, 3 months ago (2015-09-14 18:25:58 UTC) #4
Eugene But (OOO till 7-30)
On 2015/09/14 18:25:58, kkhorimoto_ wrote: > The prerender controller creates a separate tab with its ...
5 years, 3 months ago (2015-09-14 18:29:38 UTC) #5
kkhorimoto
On 2015/09/14 18:29:38, eugenebut wrote: > On 2015/09/14 18:25:58, kkhorimoto_ wrote: > > The prerender ...
5 years, 3 months ago (2015-09-14 18:36:23 UTC) #6
Eugene But (OOO till 7-30)
On 2015/09/14 18:36:23, kkhorimoto_ wrote: > On 2015/09/14 18:29:38, eugenebut wrote: > > On 2015/09/14 ...
5 years, 3 months ago (2015-09-14 18:44:42 UTC) #7
bhnascar
On 2015/09/14 18:44:42, eugenebut wrote: > On 2015/09/14 18:36:23, kkhorimoto_ wrote: > > On 2015/09/14 ...
5 years, 3 months ago (2015-09-14 20:50:21 UTC) #8
Eugene But (OOO till 7-30)
On 2015/09/14 20:50:21, bhnascar wrote: > On 2015/09/14 18:44:42, eugenebut wrote: > > On 2015/09/14 ...
5 years, 3 months ago (2015-09-14 21:00:23 UTC) #9
bhnascar
On 2015/09/14 20:50:21, bhnascar wrote: > On 2015/09/14 18:44:42, eugenebut wrote: > > On 2015/09/14 ...
5 years, 3 months ago (2015-09-14 21:00:26 UTC) #10
bhnascar
5 years, 3 months ago (2015-09-14 21:41:03 UTC) #11
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/1307103004/diff/20001/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm File ios/web/web_state/ui/crw_wk_web_view_web_controller.mm (right): https://codereview.chromium.org/1307103004/diff/20001/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm#newcode453 ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:453: // the current WKWebView's back-forward list, we can ...
5 years, 3 months ago (2015-09-14 21:48:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307103004/40001
5 years, 3 months ago (2015-09-14 22:24:30 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-14 22:39:32 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/03f902257334935fa479fbc0e5fef241b0a6dd1f Cr-Commit-Position: refs/heads/master@{#348746}
5 years, 3 months ago (2015-09-14 22:40:02 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:17 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03f902257334935fa479fbc0e5fef241b0a6dd1f
Cr-Commit-Position: refs/heads/master@{#348746}

Powered by Google App Engine
This is Rietveld 408576698