Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 13071007: linux: fix uClibc ifdeffery (Closed)

Created:
7 years, 9 months ago by Mostyn Bramley-Moore
Modified:
7 years, 8 months ago
CC:
v8-dev, robertn
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

linux: fix uClibc ifdeffery Remove duplicate inclusion of execinfo.h and make OS::DumpBacktrace a NOOP on uclibc. Committed: http://code.google.com/p/v8/source/detail?r=14172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/platform-linux.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
This was originally submitted here with the wrong account: https://codereview.chromium.org/13018002/
7 years, 9 months ago (2013-03-25 21:52:32 UTC) #1
Mostyn Bramley-Moore
Anyone able to review this small patch?
7 years, 8 months ago (2013-04-06 15:53:17 UTC) #2
Jakob Kummerow
LGTM, but I can't find your name in the list of CLA signers. Please see ...
7 years, 8 months ago (2013-04-08 09:31:27 UTC) #3
Mostyn Bramley-Moore
I believe there is an agreement signed for all Opera developers (or it is in ...
7 years, 8 months ago (2013-04-08 09:36:00 UTC) #4
Jakob Kummerow
On 2013/04/08 09:36:00, Mostyn Bramley-Moore wrote: > I believe there is an agreement signed for ...
7 years, 8 months ago (2013-04-08 09:44:38 UTC) #5
Mostyn Bramley-Moore
On 2013/04/08 09:44:38, Jakob wrote: > On 2013/04/08 09:36:00, Mostyn Bramley-Moore wrote: > > I ...
7 years, 8 months ago (2013-04-08 09:50:18 UTC) #6
Jakob Kummerow
I've learned that we're good to go. I'll land this.
7 years, 8 months ago (2013-04-09 08:02:33 UTC) #7
Jakob Kummerow
Oh, and thanks for the contribution, and sorry for the review delay!
7 years, 8 months ago (2013-04-09 08:03:46 UTC) #8
Jakob Kummerow
7 years, 8 months ago (2013-04-09 08:05:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r14172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698