Turn on component updater on chromeos, only for the pnacl component.

chrome/browser/component_updater/pnacl/pnacl_component_installer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_PNACL_PNACL_COMPONENT_INSTALLER_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_PNACL_PNACL_COMPONENT_INSTALLER_H_
 
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/component_updater/component_updater_service.h"
+#include "chrome/browser/component_updater/pnacl/pnacl_profile_observer.h"
+
+
 class CommandLine;
-class ComponentUpdateService;
 class Version;
 
 namespace base {
 class DictionaryValue;
 }
 
-// Component update registration for Portable Native Client.
-void RegisterPnaclComponent(ComponentUpdateService* cus,
-                            const CommandLine& command_line);
+class PnaclComponentInstaller : public ComponentInstaller {

[Dmitry Polukhin, 2013/03/26 11:59:56]

Nit, class comment would be nice.

[jvoung - send to chromium..., 2013/03/26 15:46:53]

Done.

+ public:
+  PnaclComponentInstaller();
+
+  virtual ~PnaclComponentInstaller();
+
+  virtual void OnUpdateError(int error) OVERRIDE;
+
+  virtual bool Install(base::DictionaryValue* manifest,
+                       const base::FilePath& unpack_path) OVERRIDE;
+
+  void RegisterPnaclComponent(ComponentUpdateService* cus,
+                              const CommandLine& command_line);
+
+#if defined(OS_CHROMEOS)

[Dmitry Polukhin, 2013/03/26 11:59:56]

Optional suggestion it looks like we can avoid all but one "#if
defined(OS_CHROMEOS)" is we make flag that distinguish user level component from
machine level. On Chrome OS we should use user level.

[jvoung - send to chromium..., 2013/03/26 15:46:53]

That's true, it would be more clear why the code is that way -- Done.

The profile observer is still if-def'ed, though, because the notification types
are only available when compiling for chromeos.

+  void ReRegisterPnacl();
+#endif
+
+  CrxComponent get_component() {
+    return pnacl_component_;
+  }
+
+  Version get_current_version() {

[Dmitry Polukhin, 2013/03/26 11:59:56]

Nit, as far as know know getters should be without "get_" prefix.

[jvoung - send to chromium..., 2013/03/26 15:46:53]

Done.

+    return pnacl_component_.version;
+  }
+
+  void set_current_version(const Version& ver) {
+    pnacl_component_.version = ver;
+  }
+
+ private:
+  scoped_ptr<PnaclProfileObserver> profile_observer_;
+  CrxComponent pnacl_component_;
+  ComponentUpdateService* cus_;
+};
 
 // Returns true if this browser is compatible with the given Pnacl component
 // manifest, with the version specified in the manifest in |version_out|.
 bool CheckPnaclComponentManifest(base::DictionaryValue* manifest,
                                  Version* version_out);
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_PNACL_PNACL_COMPONENT_INSTALLER_H_