Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1307093008: Revert of Android Media Notification: remove "Touch to return" text. (Closed)

Created:
5 years, 3 months ago by nyquist
Modified:
5 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android Media Notification: remove "Touch to return" text. (patchset #1 id:1 of https://codereview.chromium.org/1326163002/ ) Reason for revert: This breaks the downstream test HostDriven_SigninTest.testManagedSignin. Original issue's description: > Android Media Notification: remove "Touch to return" text. > > The notification only shows the origin. Touching the notification to > return to the playing application is a very common pattern on Android. > It is not required for us to reinforce it with text, making the > notification less appealing. > > BUG=528202 > > Committed: https://crrev.com/ded797a710c1a07b06f8d84d697c54671a942b35 > Cr-Commit-Position: refs/heads/master@{#347377} TBR=avayvod@chromium.org,ianwen@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528202 Committed: https://crrev.com/2fa386cfd0174b20b8ec67c3e3a2503ef479bd3a Cr-Commit-Position: refs/heads/master@{#347533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nyquist
Created Revert of Android Media Notification: remove "Touch to return" text.
5 years, 3 months ago (2015-09-04 23:41:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307093008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307093008/1
5 years, 3 months ago (2015-09-04 23:42:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 23:43:24 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2fa386cfd0174b20b8ec67c3e3a2503ef479bd3a Cr-Commit-Position: refs/heads/master@{#347533}
5 years, 3 months ago (2015-09-04 23:44:02 UTC) #4
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-09-05 14:55:07 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1306123010/ by mlamouri@chromium.org.

The reason for reverting is: Wrongful conviction..

Powered by Google App Engine
This is Rietveld 408576698