Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2551)

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view.cc

Issue 1307093004: Remove references to IsNewAvatarMenu since the flag was removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
index c4d6a7ca719158b18466c7dcdf66705d39ce22b1..8e7369be136d5724f728a7e4277e79efbcf8d40b 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
@@ -73,18 +73,26 @@ void BrowserNonClientFrameView::VisibilityChanged(views::View* starting_from,
if (!is_visible)
return;
- // The first time UpdateOldAvatarButton() is called the window is not visible
- // so DrawTaskBarDecoration() has no effect. Therefore we need to call it
- // again once the window is visible.
- if (!browser_view_->IsRegularOrGuestSession() ||
- !switches::IsNewAvatarMenu()) {
+#if defined(OS_CHROMEOS)
+ // On ChromeOS we always need to give the old avatar button a chance to update
+ // in case we're in a teleported window. On desktop, the old avatar button
+ // only shows up when in incognito mode.
+ UpdateOldAvatarButton();
+ OnProfileAvatarChanged(base::FilePath());
+#else
+ if (!browser_view_->IsRegularOrGuestSession()) {
+ // The first time UpdateOldAvatarButton() is called the window is not
+ // visible so DrawTaskBarDecoration() has no effect. Therefore we need to
+ // call it again once the window is visible.
UpdateOldAvatarButton();
}
- // Make sure the task bar icon is correctly updated call
- // |OnProfileAvatarChanged()| in this case, but only for non guest profiles.
- if (!browser_view_->IsGuestSession() || !switches::IsNewAvatarMenu())
+ // Call OnProfileAvatarChanged() in this case to make sure the task bar icon
+ // is correctly updated. Guest profiles don't badge the icon so no need to do
+ // this in guest mode.
+ if (!browser_view_->IsGuestSession())
OnProfileAvatarChanged(base::FilePath());
+#endif
}
void BrowserNonClientFrameView::ChildPreferredSizeChanged(View* child) {
@@ -179,9 +187,11 @@ int BrowserNonClientFrameView::GetTopAreaHeight() const {
}
void BrowserNonClientFrameView::UpdateAvatar() {
- if (browser_view()->IsRegularOrGuestSession() && switches::IsNewAvatarMenu())
+#if !defined(OS_CHROMEOS)
+ if (browser_view()->IsRegularOrGuestSession())
UpdateNewAvatarButtonImpl();
else
+#endif
UpdateOldAvatarButton();
}
@@ -246,7 +256,6 @@ void BrowserNonClientFrameView::UpdateOldAvatarButton() {
void BrowserNonClientFrameView::UpdateNewAvatarButton(
views::ButtonListener* listener,
const NewAvatarButton::AvatarButtonStyle style) {
- DCHECK(switches::IsNewAvatarMenu());
// This should never be called in incognito mode.
DCHECK(browser_view_->IsRegularOrGuestSession());
@@ -282,11 +291,12 @@ void BrowserNonClientFrameView::OnProfileWasRemoved(
void BrowserNonClientFrameView::OnProfileAvatarChanged(
const base::FilePath& profile_path) {
UpdateTaskbarDecoration();
- // Profile avatars are only displayed in the old UI or incognito.
- if ((!browser_view()->IsGuestSession() && browser_view()->IsOffTheRecord()) ||
- !switches::IsNewAvatarMenu()) {
+ // Profile avatars are only displayed in incognito or on ChromeOS teleported
+ // windows.
+#if !defined(OS_CHROMEOS)
+ if (!browser_view()->IsGuestSession() && browser_view()->IsOffTheRecord())
+#endif
UpdateOldAvatarButton();
- }
}
void BrowserNonClientFrameView::UpdateTaskbarDecoration() {

Powered by Google App Engine
This is Rietveld 408576698