Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: chrome/browser/resources/options/manage_profile_overlay.js

Issue 1307093004: Remove references to IsNewAvatarMenu since the flag was removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert FRAME_AVATAR_BUTTON changes. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/manage_profile_overlay.js
diff --git a/chrome/browser/resources/options/manage_profile_overlay.js b/chrome/browser/resources/options/manage_profile_overlay.js
index 5b3e41f813d011ed486966b84ef780cd20e6ce67..4426879bd81eb349947e9e823ba67486a6d2f256 100644
--- a/chrome/browser/resources/options/manage_profile_overlay.js
+++ b/chrome/browser/resources/options/manage_profile_overlay.js
@@ -95,25 +95,16 @@ cr.define('options', function() {
$('create-profile-supervised-sign-in-link').onclick =
function(event) {
- // Without the new avatar menu, the signin process will open an overlay
- // to configure sync, which would replace this overlay. It's smoother to
- // close this one now.
- // With the new avatar menu enabled, a sign-in flow in the avatar menu
- // is triggered instead, which does not open any overlays, so there's no
- // need to close this one.
- if (!loadTimeData.getBoolean('newAvatarMenuEnabled')) {
- // TODO(pamg): Move the sync-setup overlay to a higher layer so this
- // one can stay open under it, after making sure that doesn't break
- // anything else.
- PageManager.closeOverlay();
- }
+ // TODO(pamg): Move the sync-setup overlay to a higher layer so this
+ // one can stay open under it, after making sure that doesn't break
+ // anything else.
+ PageManager.closeOverlay();
SyncSetupOverlay.startSignIn();
};
$('create-profile-supervised-sign-in-again-link').onclick =
function(event) {
- if (!loadTimeData.getBoolean('newAvatarMenuEnabled'))
- PageManager.closeOverlay();
Evan Stade 2015/09/25 22:49:10 shouldn't this line be deleted too
anthonyvd 2015/09/29 20:23:15 You're right, and same thing for the one at line 1
+ PageManager.closeOverlay();
SyncSetupOverlay.showSetupUI();
};

Powered by Google App Engine
This is Rietveld 408576698