Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2375)

Unified Diff: chrome/browser/profiles/profile_list_desktop_unittest.cc

Issue 1307093004: Remove references to IsNewAvatarMenu since the flag was removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert FRAME_AVATAR_BUTTON changes. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_list_desktop_unittest.cc
diff --git a/chrome/browser/profiles/profile_list_desktop_unittest.cc b/chrome/browser/profiles/profile_list_desktop_unittest.cc
index bd79226cf028f4d07267c4ccb144e1d0e8790cba..2b053192611c10dc70a8ed2c80bbc568a02e14de 100644
--- a/chrome/browser/profiles/profile_list_desktop_unittest.cc
+++ b/chrome/browser/profiles/profile_list_desktop_unittest.cc
@@ -282,10 +282,8 @@ TEST_F(ProfileListDesktopTest, ShowAvatarMenuInTrial) {
#endif
}
+#if defined(OS_CHROMEOS)
Mike Lerman 2015/09/28 15:23:01 ChromeOS doesn't have an old avatar menu anyways,
anthonyvd 2015/09/29 20:23:15 True, it can show the icon but never the menu.
TEST_F(ProfileListDesktopTest, DontShowOldAvatarMenuForSingleProfile) {
- switches::DisableNewAvatarMenuForTesting(
- base::CommandLine::ForCurrentProcess());
-
manager()->CreateTestingProfile("Test 1");
EXPECT_FALSE(AvatarMenu::ShouldShowAvatarMenu());
@@ -299,15 +297,13 @@ TEST_F(ProfileListDesktopTest, DontShowOldAvatarMenuForSingleProfile) {
EXPECT_FALSE(AvatarMenu::ShouldShowAvatarMenu());
}
+#endif
TEST_F(ProfileListDesktopTest, AlwaysShowNewAvatarMenu) {
// If multiprofile mode is not enabled then the menu is never shown.
if (!profiles::IsMultipleProfilesEnabled())
return;
- switches::EnableNewAvatarMenuForTesting(
- base::CommandLine::ForCurrentProcess());
-
manager()->CreateTestingProfile("Test 1");
EXPECT_TRUE(AvatarMenu::ShouldShowAvatarMenu());
Mike Lerman 2015/09/28 15:23:01 Given this method implementation just does an OS c
anthonyvd 2015/09/29 20:23:15 Done.

Powered by Google App Engine
This is Rietveld 408576698