Remove references to IsNewAvatarMenu since the flag was removed.

chrome/browser/ui/cocoa/cocoa_profile_test.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_PROFILE_TEST_H_
 #define CHROME_BROWSER_UI_COCOA_PROFILE_TEST_H_
 
 #include "base/memory/scoped_ptr.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #include "chrome/test/base/testing_profile_manager.h"
@@ skipping 15 matching lines @@
 // would never be deleted and would report as a leak under Valgrind. Note that
 // these are fake threads and they all share the same MessageLoop.
 //
 // TODO(jrg): move up a level (chrome/browser/ui/cocoa -->
 // chrome/browser), and use in non-Mac unit tests such as
 // back_forward_menu_model_unittest.cc,
 // navigation_controller_unittest.cc, ..
 class CocoaProfileTest : public CocoaTest {
  public:
   CocoaProfileTest();
+  CocoaProfileTest(bool incognito);

[Robert Sesek, 2015/09/28 15:14:47]

Is this change to CocoaProfileTest really necessary? Why can't you just create a
new one-off browser in the one test where you use this ctor?

[anthonyvd, 2015/09/29 20:23:15]

I would end up pretty much copy-pasting the CocoaProfileTest and the CocoaTest
browser creation logic so I figured that it might as well be added here since it
reduces duplication and allows other eventual tests to benefit from it. If you
feel like it doesn't belong I'll be happy to move it to be specific to my test
:)

[Robert Sesek, 2015/09/29 20:31:11]

You can still inherit from CocoaProfileTest, but you just need to create a new
browser using the fixture's profile(). I don't think this belongs in a common
superclass if there's only one user.

[anthonyvd, 2015/09/30 18:34:03]

Fair point, done. I don't have access to my mac so I'll run some trybots to see
if I did it correctly.

   ~CocoaProfileTest() override;
 
   // This constructs a a Browser and a TestingProfile. It is guaranteed to
   // succeed, else it will ASSERT and cause the test to fail. Subclasses that
   // do work in SetUp should ASSERT that either browser() or profile() are
   // non-NULL before proceeding after the call to super (this).
   void SetUp() override;
 
   void TearDown() override;
 
@@ skipping 19 matching lines @@
 
   const TestingProfile::TestingFactories& testing_factories() {
     return testing_factories_;
   }
 
  private:
   TestingProfileManager profile_manager_;
   TestingProfile* profile_;  // Weak; owned by profile_manager_.
   TestingProfile::TestingFactories testing_factories_;
   scoped_ptr<Browser> browser_;
+  bool incognito_;
 
   scoped_ptr<content::TestBrowserThreadBundle> thread_bundle_;
 };
 
 #endif  // CHROME_BROWSER_UI_COCOA_PROFILE_TEST_H_