DevTools: provide an option to return traces as streams

content/browser/devtools/devtools_agent_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_agent_host_impl.h"
 
 #include <map>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 90 matching lines @@
 // static
 scoped_refptr<DevToolsAgentHost> DevToolsAgentHost::Create(
     DevToolsExternalAgentProxyDelegate* delegate) {
   return new ForwardingAgentHost(delegate);
 }
 
 void DevToolsAgentHostImpl::AttachClient(DevToolsAgentHostClient* client) {
   scoped_refptr<DevToolsAgentHostImpl> protect(this);
   if (client_) {
     client_->AgentHostClosed(this, true);
-    Detach();
+    InnerDetach();
   }
   client_ = client;
   Attach();
 }
 
 void DevToolsAgentHostImpl::DetachClient() {
   if (!client_)
     return;
 
   scoped_refptr<DevToolsAgentHostImpl> protect(this);
   client_ = NULL;
+  InnerDetach();
+}
+
+void DevToolsAgentHostImpl::InnerDetach() {
   Detach();
+  io_context_.DiscardAllStreams();

[pfeldman, 2015/08/25 20:53:41]

You could kill your object here.

 }
 
 bool DevToolsAgentHostImpl::IsAttached() {
   return !!client_;
 }
 
 void DevToolsAgentHostImpl::InspectElement(int x, int y) {
 }
 
 std::string DevToolsAgentHostImpl::GetId() {
@@ skipping 40 matching lines @@
   // removes it from the instances.
   Instances copy = g_instances.Get();
   for (Instances::iterator it(copy.begin()); it != copy.end(); ++it) {
     DevToolsAgentHostImpl* agent_host = it->second;
     if (agent_host->client_) {
       scoped_refptr<DevToolsAgentHostImpl> protect(agent_host);
       // Clear |client_| before notifying it.
       DevToolsAgentHostClient* client = agent_host->client_;
       agent_host->client_ = NULL;
       client->AgentHostClosed(agent_host, true);
-      agent_host->Detach();
+      agent_host->InnerDetach();
     }
   }
 }
 
 // static
 void DevToolsAgentHost::AddAgentStateCallback(
     const AgentStateCallback& callback) {
   g_callbacks.Get().push_back(&callback);
 }
 
@@ skipping 65 matching lines @@
 
   if (chunk.is_last) {
     CHECK(message_buffer_.size() == message_buffer_size_);
     callback_.Run(message_buffer_);
     message_buffer_ = std::string();
     message_buffer_size_ = 0;
   }
 }
 
 }  // namespace content