Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 130703003: Revert of Add use counters for using Attrs as Nodes. (Closed)

Created:
6 years, 11 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 11 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Revert of Add use counters for using Attrs as Nodes. (https://codereview.chromium.org/127723002/) Reason for revert: Adding use counters for using Attrs as Nodes regressed dom perf and others. BUG=335750 Original issue's description: > Add use counters for using Attrs as Nodes. > > DOM4 makes Attr no longer be a subtype of Node. This adds a use > counter for passing Attr where Node is expected, or calling a method > declared on Node with an Attr. > > BUG=305105 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165262 TBR=abarth@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=305105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165372

Patch Set 1 #

Patch Set 2 : Mark as removed, instead of revert-deleting, the counter enums. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -104 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 7 chunks +0 lines, -65 lines 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.cpp View 1 5 chunks +0 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 9 chunks +0 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dominicc (has gone to gerrit)
Created Revert of Add use counters for using Attrs as Nodes.
6 years, 11 months ago (2014-01-19 23:17:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/130703003/1
6 years, 11 months ago (2014-01-19 23:17:41 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-19 23:17:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/130703003/130001
6 years, 11 months ago (2014-01-19 23:33:55 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-19 23:35:00 UTC) #5
Message was sent while issue was closed.
Change committed as 165372

Powered by Google App Engine
This is Rietveld 408576698