Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1307023005: Move {next,previous}PositionOf() for VisiblePosition to VisibleUnits.cpp (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move {next,previous}PositionOf() for VisiblePosition to VisibleUnits.cpp This patch moves |{next,previous}PositionOf()| for |VisiblePosition| to "VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp" to simpler for improving code health and ease of templatizing |VisiblePosition| class to introduce composed tree version. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201500

Patch Set 1 : 2015-08-31T18:34:23 #

Patch Set 2 : 2015-08-31T22:28:28 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -110 lines) Patch
M Source/core/editing/PlainTextRange.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 2 chunks +0 lines, -103 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-31 09:51:09 UTC) #3
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-31 10:33:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307023005/1
5 years, 3 months ago (2015-08-31 10:41:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/106621)
5 years, 3 months ago (2015-08-31 10:43:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307023005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307023005/20001
5 years, 3 months ago (2015-08-31 13:29:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/97874)
5 years, 3 months ago (2015-08-31 14:12:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307023005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307023005/20001
5 years, 3 months ago (2015-08-31 19:24:57 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 20:01:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201500

Powered by Google App Engine
This is Rietveld 408576698