content/renderer/render_thread_impl.cc - Issue 1307013004: Propagate scrolling/marginwidth/marginheight property values to child frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1307013004: Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments for tests + merge blink/cr changes. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_frame_impl_browsertest.cc ('k') | content/test/data/frame_owner_properties_margin.html » ('j') | third_party/WebKit/public/web/WebFrame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_thread_impl.cc

diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc

index aa5828c3239a257791a411ec4a103d5a64ee23c5..da6a7b9f14089c1553bb6431f17405e9f9fb9262 100644

--- a/content/renderer/render_thread_impl.cc

+++ b/content/renderer/render_thread_impl.cc

@@ -1646,7 +1646,8 @@ void RenderThreadImpl::OnCreateNewFrame(FrameMsg_NewFrame_Params params) {

RenderFrameImpl::CreateFrame(

params.routing_id, params.proxy_routing_id, params.opener_routing_id,

params.parent_routing_id, params.previous_sibling_routing_id,

- params.replication_state, compositor_deps, params.widget_params);

+ params.replication_state, compositor_deps, params.widget_params,

+ params.frame_owner_properties);

}

void RenderThreadImpl::OnCreateNewFrameProxy(