Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Side by Side Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 1307013004: Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync + fix html_viewer compile Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 841 matching lines...) Expand 10 before | Expand all | Expand 10 after
852 m_webFrame->client()->didChangeName(m_webFrame, name); 852 m_webFrame->client()->didChangeName(m_webFrame, name);
853 } 853 }
854 854
855 void FrameLoaderClientImpl::didChangeSandboxFlags(Frame* childFrame, SandboxFlag s flags) 855 void FrameLoaderClientImpl::didChangeSandboxFlags(Frame* childFrame, SandboxFlag s flags)
856 { 856 {
857 if (!m_webFrame->client()) 857 if (!m_webFrame->client())
858 return; 858 return;
859 m_webFrame->client()->didChangeSandboxFlags(WebFrame::fromFrame(childFrame), static_cast<WebSandboxFlags>(flags)); 859 m_webFrame->client()->didChangeSandboxFlags(WebFrame::fromFrame(childFrame), static_cast<WebSandboxFlags>(flags));
860 } 860 }
861 861
862 void FrameLoaderClientImpl::didChangeFrameOwnerProperties(Frame* childFrame, Scr ollbarMode scrollingMode, int marginWidth, int marginHeight)
dcheng 2015/10/08 06:43:15 Instead of passing all these values, maybe just pa
lazyboy 2015/10/08 17:57:40 Passing HTMLFrameOwnerElementBase* Done.
863 {
864 if (!m_webFrame->client())
865 return;
866
867 m_webFrame->client()->didChangeFrameOwnerProperties(WebFrame::fromFrame(chil dFrame), WebFrameOwnerProperties(static_cast<WebFrameOwnerProperties::ScrollingM ode>(scrollingMode), marginWidth, marginHeight));
868 }
869
862 void FrameLoaderClientImpl::dispatchWillOpenWebSocket(WebSocketHandle* handle) 870 void FrameLoaderClientImpl::dispatchWillOpenWebSocket(WebSocketHandle* handle)
863 { 871 {
864 m_webFrame->client()->willOpenWebSocket(handle); 872 m_webFrame->client()->willOpenWebSocket(handle);
865 } 873 }
866 874
867 void FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler(WebRTCPe erConnectionHandler* handler) 875 void FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler(WebRTCPe erConnectionHandler* handler)
868 { 876 {
869 m_webFrame->client()->willStartUsingPeerConnectionHandler(webFrame(), handle r); 877 m_webFrame->client()->willStartUsingPeerConnectionHandler(webFrame(), handle r);
870 } 878 }
871 879
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
956 964
957 void FrameLoaderClientImpl::suddenTerminationDisablerChanged(bool present, Sudde nTerminationDisablerType type) 965 void FrameLoaderClientImpl::suddenTerminationDisablerChanged(bool present, Sudde nTerminationDisablerType type)
958 { 966 {
959 if (m_webFrame->client()) { 967 if (m_webFrame->client()) {
960 m_webFrame->client()->suddenTerminationDisablerChanged( 968 m_webFrame->client()->suddenTerminationDisablerChanged(
961 present, static_cast<WebFrameClient::SuddenTerminationDisablerType>( type)); 969 present, static_cast<WebFrameClient::SuddenTerminationDisablerType>( type));
962 } 970 }
963 } 971 }
964 972
965 } // namespace blink 973 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698