Propagate scrolling/marginwidth/marginheight property values to child frame.

third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

 /*
  * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 91 matching lines @@
         return;
     }
     widgetNewParentMap().set(child, parent);
 }
 
 HTMLFrameOwnerElement::HTMLFrameOwnerElement(const QualifiedName& tagName, Document& document)
     : HTMLElement(tagName, document)
     , m_contentFrame(nullptr)
     , m_widget(nullptr)
     , m_sandboxFlags(SandboxNone)
+    , m_scrollingMode(ScrollbarAuto)
+    , m_marginWidth(-1)
+    , m_marginHeight(-1)
 {
 }
 
 LayoutPart* HTMLFrameOwnerElement::layoutPart() const
 {
     // HTMLObjectElement and HTMLEmbedElement may return arbitrary layoutObjects
     // when using fallback content.
     if (!layoutObject() || !layoutObject()->isLayoutPart())
         return nullptr;
     return toLayoutPart(layoutObject());
@@ skipping 62 matching lines @@
 
 void HTMLFrameOwnerElement::setSandboxFlags(SandboxFlags flags)
 {
     m_sandboxFlags = flags;
     // Don't notify about updates if contentFrame() is null, for example when
     // the subframe hasn't been created yet.
     if (contentFrame())
         document().frame()->loader().client()->didChangeSandboxFlags(contentFrame(), flags);
 }
 
+void HTMLFrameOwnerElement::setScrollingMode(ScrollbarMode scrollbarMode)

[dcheng, 2015/10/08 06:43:15]

Can you help me understand why we moved this from HTMLFrameElementBase? It seems
to me that plugins didn't use to do this, but now they might.

[lazyboy, 2015/10/08 17:57:40]

The scrollingMode() getter is in FrameOwner super class now, so I moved the
setter here (first concrete Implementation of FrameOwner).

The other option is to return default values from scrollingMode() in this class
and override it in HTMLFrameElementBase, I did that in latest patchset, see if
that makes more sense.

+{
+    m_scrollingMode = scrollbarMode;
+    if (isPluginElement())
+        return;
+
+    frameOwnerPropertiesChanged();
+}
+
+void HTMLFrameOwnerElement::setMarginWidth(int marginWidth)
+{
+    m_marginWidth = marginWidth;
+    if (isPluginElement())
+        return;
+
+    frameOwnerPropertiesChanged();
+}
+
+void HTMLFrameOwnerElement::setMarginHeight(int marginHeight)
+{
+    m_marginHeight = marginHeight;
+    if (isPluginElement())
+        return;
+
+    frameOwnerPropertiesChanged();
+}
+
 bool HTMLFrameOwnerElement::isKeyboardFocusable() const
 {
     return m_contentFrame && HTMLElement::isKeyboardFocusable();
 }
 
+void HTMLFrameOwnerElement::frameOwnerPropertiesChanged()
+{
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeFrameOwnerProperties(contentFrame(), m_scrollingMode, m_marginWidth, m_marginHeight);
+}
+
 void HTMLFrameOwnerElement::dispatchLoad()
 {
     dispatchEvent(Event::create(EventTypeNames::load));
 }
 
 Document* HTMLFrameOwnerElement::getSVGDocument(ExceptionState& exceptionState) const
 {
     Document* doc = contentDocument();
     if (doc && doc->isSVGDocument())
         return doc;
@@ skipping 67 matching lines @@
 DEFINE_TRACE(HTMLFrameOwnerElement)
 {
     visitor->trace(m_contentFrame);
     visitor->trace(m_widget);
     HTMLElement::trace(visitor);
     FrameOwner::trace(visitor);
 }
 
 
 } // namespace blink