Propagate scrolling/marginwidth/marginheight property values to child frame.

content/browser/frame_host/frame_tree_node.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
 #define CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/browser/frame_host/render_frame_host_manager.h"
 #include "content/common/content_export.h"
 #include "content/common/frame_replication_state.h"
+#include "third_party/WebKit/public/web/WebFrameOwnerProperties.h"
 #include "url/gurl.h"
 #include "url/origin.h"
 
 namespace content {
 
 class FrameTree;
 class NavigationRequest;
 class Navigator;
 class RenderFrameHostImpl;
 
@@ skipping 18 matching lines @@
   static FrameTreeNode* GloballyFindByID(int frame_tree_node_id);
 
   FrameTreeNode(FrameTree* frame_tree,
                 Navigator* navigator,
                 RenderFrameHostDelegate* render_frame_delegate,
                 RenderViewHostDelegate* render_view_delegate,
                 RenderWidgetHostDelegate* render_widget_delegate,
                 RenderFrameHostManager::Delegate* manager_delegate,
                 blink::WebTreeScopeType scope,
                 const std::string& name,
-                blink::WebSandboxFlags sandbox_flags);
+                blink::WebSandboxFlags sandbox_flags,
+                const blink::WebFrameOwnerProperties& frame_owner_properties);
 
   ~FrameTreeNode();
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   bool IsMainFrame() const;
 
   void AddChild(scoped_ptr<FrameTreeNode> child,
                 int process_id,
@@ skipping 73 matching lines @@
 
   bool HasSameOrigin(const FrameTreeNode& node) const {
     return replication_state_.origin.IsSameOriginWith(
         node.replication_state_.origin);
   }
 
   const FrameReplicationState& current_replication_state() const {
     return replication_state_;
   }
 
+  const blink::WebFrameOwnerProperties& frame_owner_properties() {
+    return frame_owner_properties_;
+  }
+
+  void set_frame_owner_properties(
+      const blink::WebFrameOwnerProperties& frame_owner_properties) {
+    frame_owner_properties_ = frame_owner_properties;
+  }
+
   RenderFrameHostImpl* current_frame_host() const {
     return render_manager_.current_frame_host();
   }
 
   bool IsDescendantOf(FrameTreeNode* other) const;
 
   // Return the node immediately preceding this node in its parent's
   // |children_|, or nullptr if there is no such node.
   FrameTreeNode* PreviousSibling() const;
 
@@ skipping 109 matching lines @@
   // Track the effective sandbox flags for this frame.  When a parent frame
   // dynamically updates sandbox flags for a child frame, the child's updated
   // sandbox flags are stored in replication_state_.sandbox_flags. However, the
   // update only takes effect on the next frame navigation, so the effective
   // sandbox flags are tracked separately here.  When enforcing sandbox flags
   // directives in the browser process, |effective_sandbox_flags_| should be
   // used.  |effective_sandbox_flags_| is updated with any pending sandbox
   // flags when a navigation for this frame commits.
   blink::WebSandboxFlags effective_sandbox_flags_;
 
+  // Tracks the scrolling and margin properties for this frame.  These
+  // properties affect the child renderer but are stored on its parent's
+  // frame element.  When this frame's parent dynamically updates these
+  // properties, we store them here.

[alexmos, 2015/10/02 21:24:19]

nit: last sentence makes it sound like the properties are only stored on dynamic
updates, but they're also stored when the child frame is first created.

[lazyboy, 2015/10/05 22:16:08]

Changed "store" to "update".

+  //
+  // Note that the update only takes effect on the next frame navigation,

[alexmos, 2015/10/02 21:24:19]

nit: s/the update/dynamic updates/, s/takes/take/.  I'd also remove "to be
consistent...", since the code here doesn't do anything to be consistent with
Blink -- that happens on the Blink side in WebFrame::setFrameOwnerProperties.

[lazyboy, 2015/10/05 22:16:08]

Done.

+  // to be consistent with current Blink implementation.
+  blink::WebFrameOwnerProperties frame_owner_properties_;
+
   // Used to track this node's loading progress (from 0 to 1).
   double loading_progress_;
 
   // PlzNavigate
   // Owns an ongoing NavigationRequest until it is ready to commit. It will then
   // be reset and a RenderFrameHost will be responsible for the navigation.
   scoped_ptr<NavigationRequest> navigation_request_;
 
   // List of objects observing this FrameTreeNode.
   base::ObserverList<Observer> observers_;
 
   base::TimeTicks last_focus_time_;
 
   DISALLOW_COPY_AND_ASSIGN(FrameTreeNode);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_