LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html - Issue 1306993005: Paint invalidation tests of composited-non-stacking-context descendant

Side by Side Diff: LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html

Issue 1306993005: Paint invalidation tests of composited-non-stacking-context descendant (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/paint/invalidation/composited-non-stacking-context-descendant-move-expected.html ('k') | LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 #container {	3 #container {

4 position: fixed;	4 position: fixed;

5 top: 200px;	5 top: 200px;

6 left: 100px;	6 left: 100px;

7 }	7 }

8	8

9 #block {	9 #block {

10 position: relative;	10 position: relative;

11 width: 100px;	11 width: 100px;

12 height: 100px;	12 height: 100px;

	13 top: 50px;
	Xianzhu 2015/08/25 18:35:59 This is added to avoid it from overlapping with #c This is added to avoid it from overlapping with #composited-non-stacking-context which would cause this div to be composited. chrishtr 2015/08/25 18:49:03 Please add a test instead of modifying this one. O Show quoted text On 2015/08/25 at 18:35:59, Xianzhu wrote: > This is added to avoid it from overlapping with #composited-non-stacking-context which would cause this div to be composited. Please add a test instead of modifying this one. Otherwise we lose test coverage. Xianzhu 2015/08/25 18:52:40 Actually this fixes coverage of the original test Show quoted text On 2015/08/25 18:49:03, chrishtr wrote: > On 2015/08/25 at 18:35:59, Xianzhu wrote: > > This is added to avoid it from overlapping with > #composited-non-stacking-context which would cause this div to be composited. > > Please add a test instead of modifying this one. Otherwise we lose test > coverage. Actually this fixes coverage of the original test which was the same as fixed-position-descendant-paint-offset.html because #composited-non-stacking-context did nothing without the added properties.
13 background-color: green;	14 background-color: green;

14 }	15 }

15	16

16 #composited-non-stacking-context {	17 #composited-non-stacking-context {

	18 width: 20px;

	19 height: 20px;

	20 background-color: white;
	Xianzhu 2015/08/25 18:35:59 Note: these properties are added to ensure the div Note: these properties are added to ensure the div is composited. Otherwise it's not because it's empty.
17 backface-visibility: hidden;	21 backface-visibility: hidden;

18 }	22 }

19 </style>	23 </style>

20 <div id="container">	24 <div id="container">

21 <div id="composited-non-stacking-context">	25 <div id="composited-non-stacking-context">

22 <div id="block"></div>	26 <div id="block"></div>

23 </div>	27 </div>

24 </div>	28 </div>

25 This test passes if the green block stays at the same place after repaint.	29 This test passes if the green block stays at the same place after repaint.

26 <script src="../../resources/run-after-layout-and-paint.js"></script>	30 <script src="../../resources/run-after-layout-and-paint.js"></script>

27 <script>	31 <script>

28 runAfterLayoutAndPaint(function() {	32 runAfterLayoutAndPaint(function() {

29 document.getElementById("container").style.top = "100px";	33 document.getElementById("container").style.top = "100px";

30 document.getElementById("block").style.top = "100px";	34 document.getElementById("block").style.top = "100px";

31 }, true);	35 }, true);

32 </script>	36 </script>

OLD	NEW