Paint invalidation tests of composited-non-stacking-context descendant

Paint invalidation tests of composited-non-stacking-context descendant

BUG=524596
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201169

[Xianzhu, 2015-08-25 18:34:19]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, trchen@chromium.org

[Xianzhu, 2015-08-25 18:35:59]

https://codereview.chromium.org/1306993005/diff/1/LayoutTests/paint/invalidat...
File
LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html
(right):

https://codereview.chromium.org/1306993005/diff/1/LayoutTests/paint/invalidat...
LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html:13:
top: 50px;
This is added to avoid it from overlapping with #composited-non-stacking-context
which would cause this div to be composited.

https://codereview.chromium.org/1306993005/diff/1/LayoutTests/paint/invalidat...
LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html:20:
background-color: white;
Note: these properties are added to ensure the div is composited. Otherwise it's
not because it's empty.

[chrishtr, 2015-08-25 18:49:03]

https://codereview.chromium.org/1306993005/diff/1/LayoutTests/paint/invalidat...
File
LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html
(right):

https://codereview.chromium.org/1306993005/diff/1/LayoutTests/paint/invalidat...
LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html:13:
top: 50px;
On 2015/08/25 at 18:35:59, Xianzhu wrote:
> This is added to avoid it from overlapping with
#composited-non-stacking-context which would cause this div to be composited.

Please add a test instead of modifying this one. Otherwise we lose test
coverage.

[Xianzhu, 2015-08-25 18:52:40]

https://codereview.chromium.org/1306993005/diff/1/LayoutTests/paint/invalidat...
File
LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html
(right):

https://codereview.chromium.org/1306993005/diff/1/LayoutTests/paint/invalidat...
LayoutTests/paint/invalidation/fixed-position-descendant-paint-offset-indirect.html:13:
top: 50px;
On 2015/08/25 18:49:03, chrishtr wrote:
> On 2015/08/25 at 18:35:59, Xianzhu wrote:
> > This is added to avoid it from overlapping with
> #composited-non-stacking-context which would cause this div to be composited.
> 
> Please add a test instead of modifying this one. Otherwise we lose test
> coverage.

Actually this fixes coverage of the original test which was the same as
fixed-position-descendant-paint-offset.html because
#composited-non-stacking-context did nothing without the added properties.

[chrishtr, 2015-08-25 18:58:05]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-08-25 18:58:06]

lgtm

[commit-bot: I haz the power, 2015-08-25 18:58:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306993005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306993005/1

[commit-bot: I haz the power, 2015-08-25 19:25:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 19:25:07]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2015-08-25 20:44:33]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-08-25 20:44:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306993005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306993005/1

[commit-bot: I haz the power, 2015-08-25 21:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 21:41:48]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2015-08-25 21:42:52]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-08-25 21:42:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306993005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306993005/1

[commit-bot: I haz the power, 2015-08-25 22:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 22:30:30]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2015-08-25 23:22:52]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-08-25 23:23:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306993005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306993005/1

[commit-bot: I haz the power, 2015-08-25 23:57:35]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201169