Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: LayoutTests/fast/events/overflow-scroll-fake-mouse-move.html

Issue 1306993002: Cleanup friends of LayoutObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/events/overflow-scroll-fake-mouse-move.html
diff --git a/LayoutTests/fast/events/overflow-scroll-fake-mouse-move.html b/LayoutTests/fast/events/overflow-scroll-fake-mouse-move.html
index 13e72b76e43f68119f2dee98072914d25278a562..7a49a3f315b919356a306e4618cddffa9619a7b0 100644
--- a/LayoutTests/fast/events/overflow-scroll-fake-mouse-move.html
+++ b/LayoutTests/fast/events/overflow-scroll-fake-mouse-move.html
@@ -1,18 +1,17 @@
<div id="target" style="overflow: auto; height: 200px; width: 200px;">
<div onmouseover="mouseOver(event)" style="margin: 300px 0; width: 100px; height: 100px; background-color: blue;"></div>
</div>
-<div id="result">Test did not run</div>
+<div id="result">Test needs DumpRenderTree</div>
<script>
- var passed = false;
-
function mouseOver(event)
{
- passed = true;
+ document.getElementById("result").innerText = "PASS";
+ testRunner.notifyDone();
}
- function finish()
+ function fail()
{
- document.getElementById("result").innerText = passed ? "PASS" : "FAIL";
+ document.getElementById("result").innerText = "FAIL";
testRunner.notifyDone();
}
@@ -20,14 +19,11 @@
testRunner.dumpAsText();
testRunner.waitUntilDone();
- // WebKit schedules a fake mouse move event as part of installing the WebView in
- // a window. For the test to be valid, it must begin only after that event
- // gets dispatched.
- setTimeout(function()
+ onload = function()
{
eventSender.mouseMoveTo(50, 100);
document.getElementById("target").scrollTop = 250;
- setTimeout(finish, 200);
- }, 200);
+ setTimeout(fail, 1000);
esprehn 2015/08/21 21:20:31 A 1 second timeout is really bad, what is this tes
Xianzhu 2015/08/21 22:52:19 This timeout happens only on failure. Previously w
+ };
}
</script>

Powered by Google App Engine
This is Rietveld 408576698