Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1306983003: Use runtime ABI instead of hw architecture when processing microdumps (Closed)

Created:
5 years, 4 months ago by mmandlis
Modified:
5 years, 3 months ago
CC:
google-breakpad-dev_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

The "CPU architecture" field is being filled from the wrong part of the microdump. The microdump OS/arch line looks like: O A arm 04 armv7l 3.4.0-perf-g4d6e88e #1 SMP PREEMPT Mon Mar 30 19:09:30 2015 and currently the field that says "armv7l" or "aarch64" is being used to fill in the CPU arch field in crash. The problem is that on a 64-bit device this field *always* says "aarch64" even when running in a 32-bit process, and so currently the crash reports for aarch64 are a mix of 32-bit and 64-bit crashes. We should be using the first field instead, which just says "arm" or "arm64" and reflects the actual version of webview (32-bit or 64-bit) which is running. BUG= R=primiano@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1498

Patch Set 1 #

Patch Set 2 : Update unittests #

Patch Set 3 : Fix microdump stackwalker test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -25 lines) Patch
M src/processor/microdump.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/microdump_processor_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/processor/testdata/microdump.stackwalk-arm.out View 1 2 2 chunks +26 lines, -9 lines 0 comments Download
M src/processor/testdata/microdump.stackwalk-arm64.out View 1 2 2 chunks +74 lines, -10 lines 0 comments Download
M src/processor/testdata/microdump.stackwalk.machine_readable-arm.out View 1 1 chunk +1 line, -1 line 0 comments Download
M src/processor/testdata/microdump.stackwalk.machine_readable-arm64.out View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Primiano Tucci (use gerrit)
Code LGTM, but please reformat the CL description. Should look like Subject line (e.g., "Use ...
5 years, 4 months ago (2015-08-25 07:55:55 UTC) #2
Primiano Tucci (use gerrit)
On 2015/08/25 07:55:55, Primiano Tucci wrote: > Code LGTM, but please reformat the CL description. ...
5 years, 4 months ago (2015-08-25 07:58:44 UTC) #3
mmandlis
All the tests are passing now, thanks for your help. PTAL, does it still look ...
5 years, 4 months ago (2015-08-25 22:27:38 UTC) #4
Primiano Tucci (use gerrit)
On 2015/08/25 22:27:38, mmandlis wrote: > All the tests are passing now, thanks for your ...
5 years, 4 months ago (2015-08-25 22:46:57 UTC) #5
mmandlis
5 years, 3 months ago (2015-08-26 16:19:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 1498 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698