Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306963004: Remove sys/types.h include from SkTypes.h. (Closed)

Created:
5 years, 3 months ago by bungeman-skia
Modified:
5 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove sys/types.h include from SkTypes.h. It appears this was added to support SkToOffT, but SkToOffT is no longer used, so it is removed as well. Committed: https://skia.googlesource.com/skia/+/7445cef42f52e15de800207e8b14a3b24f444148

Patch Set 1 #

Patch Set 2 : Also remove SkToOffT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M include/core/SkTypes.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkDebug.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306963004/1
5 years, 3 months ago (2015-08-27 22:06:00 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/2946)
5 years, 3 months ago (2015-08-27 22:07:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306963004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306963004/20001
5 years, 3 months ago (2015-08-27 22:17:13 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 23:43:39 UTC) #8
bungeman-skia
bsalomon, you're the reviewer since it appears you added this with ef3fcd877aa78c1d0ac802043cd8785180304c12 .
5 years, 3 months ago (2015-08-28 14:15:21 UTC) #10
reed1
lgtm
5 years, 3 months ago (2015-08-28 14:26:44 UTC) #12
bsalomon
lgtm
5 years, 3 months ago (2015-08-28 14:35:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306963004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306963004/20001
5 years, 3 months ago (2015-08-28 14:39:02 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 14:39:33 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7445cef42f52e15de800207e8b14a3b24f444148

Powered by Google App Engine
This is Rietveld 408576698