Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1306953006: Run Appurify bot in release mode (Closed)

Created:
5 years, 3 months ago by borenet
Modified:
5 years, 3 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : sign #

Total comments: 3

Patch Set 3 : revert changes to skia_android.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M platform_tools/android/apps/visualbench/build.gradle View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/buildbot_spec.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
borenet
5 years, 3 months ago (2015-08-31 16:00:39 UTC) #2
djsollen
https://codereview.chromium.org/1306953006/diff/20001/platform_tools/android/gyp/skia_android.gypi File platform_tools/android/gyp/skia_android.gypi (right): https://codereview.chromium.org/1306953006/diff/20001/platform_tools/android/gyp/skia_android.gypi#newcode46 platform_tools/android/gyp/skia_android.gypi:46: 'android_test_apk_suffix': 'debug-androidTest-unaligned.apk', I'm not sure these new suffix variables ...
5 years, 3 months ago (2015-08-31 16:09:37 UTC) #3
djsollen
https://codereview.chromium.org/1306953006/diff/20001/platform_tools/android/gyp/skia_android.gypi File platform_tools/android/gyp/skia_android.gypi (right): https://codereview.chromium.org/1306953006/diff/20001/platform_tools/android/gyp/skia_android.gypi#newcode46 platform_tools/android/gyp/skia_android.gypi:46: 'android_test_apk_suffix': 'debug-androidTest-unaligned.apk', On 2015/08/31 16:09:37, djsollen wrote: > I'm ...
5 years, 3 months ago (2015-08-31 16:16:08 UTC) #4
borenet
https://codereview.chromium.org/1306953006/diff/20001/platform_tools/android/gyp/skia_android.gypi File platform_tools/android/gyp/skia_android.gypi (right): https://codereview.chromium.org/1306953006/diff/20001/platform_tools/android/gyp/skia_android.gypi#newcode46 platform_tools/android/gyp/skia_android.gypi:46: 'android_test_apk_suffix': 'debug-androidTest-unaligned.apk', On 2015/08/31 16:16:08, djsollen wrote: > On ...
5 years, 3 months ago (2015-08-31 16:18:34 UTC) #5
djsollen
lgtm
5 years, 3 months ago (2015-08-31 16:23:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306953006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306953006/40001
5 years, 3 months ago (2015-08-31 16:24:55 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 16:31:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5e04bcfddde2ab22a04187199e9a953523886cf6

Powered by Google App Engine
This is Rietveld 408576698