Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 130693010: Rename NavigatorServiceWorkerInterface to ServiceWorkerContainer (Closed)

Created:
6 years, 10 months ago by kinuko
Modified:
6 years, 10 months ago
Reviewers:
alecflett, tzik
CC:
blink-reviews
Visibility:
Public.

Description

Rename NavigatorServiceWorkerInterface to ServiceWorkerContainer Per the latest spec change (thanks to Alec for raising this issue): https://github.com/slightlyoff/ServiceWorker/commit/5ef8bdd6f7a26beff131d0f04b680de10d29e43c BUG=285976 TEST=http/tests/serviceworker Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -249 lines) Patch
M Source/modules/modules.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.idl View 1 chunk +1 line, -1 line 0 comments Download
D Source/modules/serviceworkers/NavigatorServiceWorkerInterface.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/modules/serviceworkers/NavigatorServiceWorkerInterface.cpp View 1 chunk +0 lines, -117 lines 0 comments Download
D Source/modules/serviceworkers/NavigatorServiceWorkerInterface.idl View 1 chunk +0 lines, -38 lines 0 comments Download
A + Source/modules/serviceworkers/ServiceWorkerContainer.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
A + Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
Taiju, would you be able to review this?
6 years, 10 months ago (2014-02-12 14:00:28 UTC) #1
tzik
LGTM if it compile.
6 years, 10 months ago (2014-02-12 14:02:07 UTC) #2
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 10 months ago (2014-02-12 14:03:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/130693010/1
6 years, 10 months ago (2014-02-12 14:03:07 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 17:06:42 UTC) #5
Message was sent while issue was closed.
Change committed as 167021

Powered by Google App Engine
This is Rietveld 408576698