Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1306913003: Revert of Turn VariationsService::GetVariationsServerURL into instance method (Closed)

Created:
5 years, 3 months ago by blundell
Modified:
5 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn VariationsService::GetVariationsServerURL into instance method (patchset #5 id:140001 of https://codereview.chromium.org/1313213005/ ) Reason for revert: Gak! The CreateForTesting method can't call the Create method because the latter returns null in non-official builds -- exactly the problem from the original CL :P. I don't understand why this CL passed trybots. Original issue's description: > Turn VariationsService::GetVariationsServerURL into instance method > > This will allow for followup work that uses |client_| within that > method. > > Reland of https://codereview.chromium.org/1309843005 with the browsertests > fixed to remove the unsafe accesses to g_browser_process->variations_service(). > > BUG=516678 > > Committed: https://crrev.com/dcc53f65eb04018ca60b077a55aa5923ac5e8e9c > Cr-Commit-Position: refs/heads/master@{#346878} TBR=asvitkine@chromium.org,bartfab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516678 Committed: https://crrev.com/e6074b23a75c0e4bddffb1ce326d2c80f1dd4e3c Cr-Commit-Position: refs/heads/master@{#346884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -88 lines) Patch
M chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 3 chunks +10 lines, -15 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 4 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 10 chunks +26 lines, -39 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 3 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blundell
Created Revert of Turn VariationsService::GetVariationsServerURL into instance method
5 years, 3 months ago (2015-09-02 11:23:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306913003/1
5 years, 3 months ago (2015-09-02 11:23:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 11:24:04 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 11:24:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6074b23a75c0e4bddffb1ce326d2c80f1dd4e3c
Cr-Commit-Position: refs/heads/master@{#346884}

Powered by Google App Engine
This is Rietveld 408576698