Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1306873003: Added example of chrome.i18n.detectLanguage (Closed)

Created:
5 years, 4 months ago by amalika
Modified:
5 years, 3 months ago
Reviewers:
mkearney1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, smn, chaotian1, mcindy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Example extension that uses new extension API chrome.i18n.detectLanguage API Proposal: https://docs.google.com/document/d/1XuE16b2Ra7ay_fpjL5z9qiCtL2BCXzWHbeGvP5_JX7w Landed CL for the extension API:https://codereview.chromium.org/1273903002 BUG=517628 Committed: https://crrev.com/2fb750df5574e5eade28daedcc3ff745c02a09ce Cr-Commit-Position: refs/heads/master@{#347480}

Patch Set 1 #

Patch Set 2 : Updating the intros #

Total comments: 4

Patch Set 3 : Better formatting #

Total comments: 2

Patch Set 4 : Fixing whitespaces in html #

Patch Set 5 : Added License header in comments in js file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
A + chrome/common/extensions/docs/examples/api/i18n/detectLanguage/icon.png View Binary file 0 comments Download
A chrome/common/extensions/docs/examples/api/i18n/detectLanguage/manifest.json View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/i18n/detectLanguage/popup.html View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/i18n/detectLanguage/popup.js View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/i18n.html View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
amalika
5 years, 4 months ago (2015-08-25 23:05:18 UTC) #2
amalika
Updated the docs of i18n docs with chrome.i18n.detectLanguage details.
5 years, 3 months ago (2015-08-28 15:48:59 UTC) #6
mkearney1
Hey, Main review comment-- did you mean to replace the icon with a new one? ...
5 years, 3 months ago (2015-09-03 17:29:16 UTC) #7
amalika
I hope icon is uploaded now! https://codereview.chromium.org/1306873003/diff/20001/chrome/common/extensions/docs/examples/api/i18n/detectLanguage/manifest.json File chrome/common/extensions/docs/examples/api/i18n/detectLanguage/manifest.json (right): https://codereview.chromium.org/1306873003/diff/20001/chrome/common/extensions/docs/examples/api/i18n/detectLanguage/manifest.json#newcode7 chrome/common/extensions/docs/examples/api/i18n/detectLanguage/manifest.json:7: "default_icon": "icon.png", On ...
5 years, 3 months ago (2015-09-03 21:37:45 UTC) #9
mkearney1
lgtm so long as whitespace errors are fixed. I'm seeing the image in it's folder ...
5 years, 3 months ago (2015-09-04 19:56:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306873003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306873003/60001
5 years, 3 months ago (2015-09-04 20:04:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/96798)
5 years, 3 months ago (2015-09-04 20:13:52 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306873003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306873003/80001
5 years, 3 months ago (2015-09-04 20:19:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306873003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306873003/80001
5 years, 3 months ago (2015-09-04 20:28:50 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-04 20:33:54 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 20:34:35 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2fb750df5574e5eade28daedcc3ff745c02a09ce
Cr-Commit-Position: refs/heads/master@{#347480}

Powered by Google App Engine
This is Rietveld 408576698