Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/sqlite/sqlite.gyp

Issue 1306863006: [sqlite] Respect the gyp and gn component switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back to final CL to land. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/sqlite/BUILD.gn ('K') | « third_party/sqlite/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sqlite/sqlite.gyp
diff --git a/third_party/sqlite/sqlite.gyp b/third_party/sqlite/sqlite.gyp
index 61bfd9d06ca9ab8c5679eb19ed816e440224691f..f4b3175b7ec7c9c5f9a3db92accb3877940831eb 100644
--- a/third_party/sqlite/sqlite.gyp
+++ b/third_party/sqlite/sqlite.gyp
@@ -116,7 +116,7 @@
],
}, { # !use_system_sqlite
'product_name': 'sqlite3',
- 'type': 'static_library',
+ 'type': '<(component)',
'sources': [
'amalgamation/sqlite3.h',
'amalgamation/sqlite3.c',
@@ -148,6 +148,15 @@
4244, 4267,
],
'conditions': [
+ ['OS == "win" and component == "shared_library"', {
+ 'defines': ['SQLITE_API=__declspec(dllexport)'],
+ 'direct_dependent_settings': {
+ 'defines': ['SQLITE_API=__declspec(dllimport)'],
+ },
+ }],
+ ['OS != "win" and component == "shared_library"', {
+ 'defines': ['SQLITE_API=__attribute__((visibility("default")))'],
+ }],
['OS=="linux"', {
'link_settings': {
'libraries': [
@@ -159,6 +168,7 @@
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework',
+ '$(SDKROOT)/System/Library/Frameworks/CoreServices.framework',
],
},
}],
« third_party/sqlite/BUILD.gn ('K') | « third_party/sqlite/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698