[sqlite] Respect the gyp and gn component switch.

[sqlite] Respect the gyp and gn component switch.

SQLITE_API is the existing mechanism SQLite provides, and is used in
preference to inventing a new SQLITE_EXPORT symbol (like
sql/sql_export.h and other examples).

CoreServices.framework is necessary on OSX because of the Time Machine
patch.

Remove sql/proxy.{h,cc}, which was necessary to work around SQLite
linking statically into both component shlibs and unit test executables.

[Relanding https://codereview.chromium.org/1322463002/ ]

BUG=489444
TBR=michaeln@chromium.org, thakis@chromium.org, brettw@chromium.org

Committed: https://crrev.com/f71db5c36625ff00feb8283028631303ae5caa7c
Cr-Commit-Position: refs/heads/master@{#346536}

[Scott Hess - ex-Googler, 2015-08-31 19:46:23]

Original version of CL

[Scott Hess - ex-Googler, 2015-08-31 20:08:53]

First reland of CL

[Scott Hess - ex-Googler, 2015-08-31 20:11:43]

Back to final CL to land.

[Scott Hess - ex-Googler, 2015-08-31 20:17:54]

shess@chromium.org changed reviewers:
+ brettw@chromium.org, michaeln@chromium.org, thakis@chromium.org

[Scott Hess - ex-Googler, 2015-08-31 20:17:54]

OK, last try is for all the beans.

Consulted Brett about how to manage the variation between implementation and
interface definition of SQLITE_API.  When I described the structure in the last
patch, he said "Yeah, that's basically the way to do it".

Contrary to prior passes through this, I managed to test the windows build with
is_component_build = true, rather than the default.  Sigh.

[Scott Hess - ex-Googler, 2015-08-31 20:18:04]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 20:19:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306863006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306863006/60001

[commit-bot: I haz the power, 2015-08-31 20:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 20:47:05]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-08-31 20:56:59]

All The Beans LGTM

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:16: include_dirs = [ "." ]
I think you can just add this to the sqlite_export config below and delete this
as a standalone config.

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:123: group("sqlite") {
It might be nice to add a comment about why this is here (to apply
*export/*config configs to dependents without applying them to the sqlite code)

[Scott Hess - ex-Googler, 2015-08-31 21:06:49]

Thanks for looking at it...

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:16: include_dirs = [ "." ]
On 2015/08/31 20:56:59, brettw wrote:
> I think you can just add this to the sqlite_export config below and delete
this
> as a standalone config.

I probably could, but I've become very conservative over this CL, I'd rather not
have to re-land it again.  It took all of my gumption not to break the change up
by platform...

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:123: group("sqlite") {
On 2015/08/31 20:56:59, brettw wrote:
> It might be nice to add a comment about why this is here (to apply
> *export/*config configs to dependents without applying them to the sqlite
code)

Acknowledged.

[Scott Hess - ex-Googler, 2015-08-31 21:06:59]

Comment use of group.

[brettw, 2015-08-31 21:11:05]

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:16: include_dirs = [ "." ]
Can you do that as a followup?

[Scott Hess - ex-Googler, 2015-08-31 21:15:59]

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/1306863006/diff/60001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:16: include_dirs = [ "." ]
On 2015/08/31 21:11:05, brettw wrote:
> Can you do that as a followup?

Definitely, http://crbug.com/526828

[Scott Hess - ex-Googler, 2015-08-31 22:29:29]

rebase

[Scott Hess - ex-Googler, 2015-08-31 23:11:27]

The CQ bit was checked by shess@chromium.org

[Scott Hess - ex-Googler, 2015-08-31 23:11:28]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1306863006/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-31 23:11:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306863006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306863006/100001

[Scott Hess - ex-Googler, 2015-08-31 23:13:28]

Sheriff: Previous iterations of this change caused issues with the gn bots in
the gn phase.

[commit-bot: I haz the power, 2015-09-01 00:31:00]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-09-01 00:31:35]

Patchset 6 (id:??) landed as
https://crrev.com/f71db5c36625ff00feb8283028631303ae5caa7c
Cr-Commit-Position: refs/heads/master@{#346536}

[Paweł Hajdan Jr., 2015-09-01 10:19:37]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1325833003/ by phajdan.jr@chromium.org.

The reason for reverting is: Suspected of breaking chromium.webkit Mac builders,
see https://code.google.com/p/chromium/issues/detail?id=526208

Summary:

Incompatible library version: httpd requires version 9.0.0 or later, but
libsqlite3.dylib provides version 0.0.0

/b/build/slave/WebKit_Mac10_6__dbg_/build/src/out/Debug/libsqlite3.dylib seems
to be used instead of expected/intended /usr/lib/libsqlite3.dylib.