CmaMediaPipelineClient to watch media pipeline status

chromecast/browser/media/cma_media_pipeline_client.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMECAST_BROWSER_MEDIA_CMA_MEDIA_PIPELINE_CLIENT_H_
+#define CHROMECAST_BROWSER_MEDIA_CMA_MEDIA_PIPELINE_CLIENT_H_
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "chromecast/cast/cast_resource.h"
+#include "chromecast/public/media/media_pipeline_backend.h"
+
+namespace chromecast {
+namespace media {
+
+// Class to provide media backend and watch media pipeline status
+class CmaMediaPipelineClient : public base::RefCounted<CmaMediaPipelineClient>,
+                               public cast::CastResource {

[halliwell, 2015/09/01 20:16:34]

Is this class really necessary any more?

I'm wondering if we could eliminate a bunch of code by:
* Setting the CastResource::Client directly on the backend object
* Call Acquired when the backend is initialised, Released when it's destroyed
* Go back to having the browser client create the backend directly, remove this
class and the internal subclass

Thoughts?

[yucliu1, 2015/09/01 23:42:13]

This needs to create another class to wrap the media pipeline.

+ public:
+  CmaMediaPipelineClient();
+
+  virtual scoped_ptr<MediaPipelineBackend> CreateMediaPipelineBackend(
+      const media::MediaPipelineDeviceParams& params);
+
+  virtual void OnMediaPipelineBackendCreated();
+  virtual void OnMediaPipelineBackendDestroyed();
+
+  // cast::CastResource implementations
+  void ReleaseResource(cast::CastResource::Resource resource) override;
+  void SetCastResourceClient(cast::CastResource::Client* client) override;
+
+ protected:
+  ~CmaMediaPipelineClient() override;
+
+  cast::CastResource::Client* client_;
+
+ private:
+  friend class base::RefCounted<CmaMediaPipelineClient>;
+  DISALLOW_COPY_AND_ASSIGN(CmaMediaPipelineClient);
+};
+}
+}
+
+#endif