LayoutTests/media/track/track-cue-rendering-line-doesnt-fit.html - Issue 1306833003: Sync snap-to-lines VTT cue layout steps with spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/track-cue-rendering-line-doesnt-fit.html

Issue 1306833003: Sync snap-to-lines VTT cue layout steps with spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../media-file.js"></script>	2 <script src="../media-file.js"></script>

3 <script>	3 <script>

4 var mediaFile = findMediaFile('video', '../content/test');	4 var mediaFile = findMediaFile('video', '../content/test');

5	5

6 function addTrackWithCueData(video, cueData) {	6 function addCue(track, cueData) {

7 var track = video.addTextTrack('subtitles');

8 var cue = new VTTCue(0, 10, 'XXX');	7 var cue = new VTTCue(0, 10, 'XXX');

9 for (var prop in cueData)	8 for (var prop in cueData)

10 cue[prop] = cueData[prop];	9 cue[prop] = cueData[prop];

11 track.addCue(cue);	10 track.addCue(cue);

12 track.mode = 'showing';

13 }	11 }

14 </script>	12 </script>

15 <style>	13 <style>

16 video::cue {	14 video::cue {

17 font-size: 50px;	15 font-size: 120px;

18 color: green;	16 color: green;

19 background-color: green;	17 background-color: green;

20 }	18 }

21 </style>	19 </style>

22 <video>	20 <video>

23 <script>	21 <script>

24 var video = document.currentScript.parentNode;	22 var video = document.currentScript.parentNode;

25 addTrackWithCueData(video, { align: 'start', line: 0 });	23 var track = video.addTextTrack('subtitles');

	24 addCue(track, { line: 0, align: 'start' });
	philipj_slow 2015/08/21 10:55:03 Perhaps comment here which of these is expected to Perhaps comment here which of these is expected to be visible and which will be pushed out, and even give them different texts so that one could tell just by looking at the result? fs 2015/08/21 12:02:31 Sure. Hope you don't mind that the textContent wil Show quoted text On 2015/08/21 10:55:03, philipj wrote: > Perhaps comment here which of these is expected to be visible and which will be > pushed out, and even give them different texts so that one could tell just by > looking at the result? Sure. Hope you don't mind that the textContent will be 'PAS' and 'FAI' =) (the font-size is pretty "well" tweaked for the purpose, and since 'PASS' and 'FAIL' run a risk of being different width, etc...)
	25 addCue(track, { line: 1, align: 'start' });

	26 track.mode = 'showing';

26 video.src = mediaFile;	27 video.src = mediaFile;

27 </script>	28 </script>

28 </video>	29 </video>

29 <video>

30 <script>

31 var video = document.currentScript.parentNode;

32 addTrackWithCueData(video, { align: 'middle', line: 0 });

33 video.src = mediaFile;

34 </script>

35 </video>

36 <video>

37 <script>

38 var video = document.currentScript.parentNode;

39 addTrackWithCueData(video, { align: 'end', line: 0 });

40 video.src = mediaFile;

41 </script>

42 </video>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/track/track-cue-rendering-line-doesnt-fit-expected.html » ('j') | Source/core/layout/LayoutVTTCue.cpp » ('J')