Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1306833002: X87: [turbofan] Support unboxed float and double stack parameters and add tests. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Support unboxed float and double stack parameters and add tests. port 0492bb3291c838d7e11261abc32af58bed58bcf0 (r30203). original commit message: BUG= Committed: https://crrev.com/ab6751451dfba9f7d7ef6a17f60ac15556d6ede0 Cr-Commit-Position: refs/heads/master@{#30290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +23 lines, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-08-21 09:26:30 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-08-21 09:41:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306833002/1
5 years, 4 months ago (2015-08-21 09:42:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 10:20:17 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 10:20:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab6751451dfba9f7d7ef6a17f60ac15556d6ede0
Cr-Commit-Position: refs/heads/master@{#30290}

Powered by Google App Engine
This is Rietveld 408576698