Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1306823005: [turbofan] greedy: heuristic for memory operands (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] greedy: heuristic for memory operands When we have a memory operand (HasSpillOperand() == true), and it doesn't need a register immediately, split in an optimal position, which is outside the outermost possible loop - just like Linear does. This results in some modest improvements in perf, when compared to baseline greedy. In particular Jetstream zlib x64: 4.66%, Life (Emscripten x64) 11%; largest regression is in AreWeFastYet x64: 8% and Corrections (Emsccripten x32) 10% BUG= Committed: https://crrev.com/8937bfc1d165ff6d72dede1b0ce6f7c1ab9fb260 Cr-Commit-Position: refs/heads/master@{#30498}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/compiler/greedy-allocator.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mircea Trofin
5 years, 3 months ago (2015-09-01 08:12:07 UTC) #3
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-01 08:23:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306823005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306823005/40001
5 years, 3 months ago (2015-09-01 08:28:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-01 08:54:40 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8937bfc1d165ff6d72dede1b0ce6f7c1ab9fb260 Cr-Commit-Position: refs/heads/master@{#30498}
5 years, 3 months ago (2015-09-01 08:54:54 UTC) #8
Michael Achenbach
5 years, 3 months ago (2015-09-01 09:37:09 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1311813005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks test with greedy allocator:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20g....

Powered by Google App Engine
This is Rietveld 408576698