third_party/WebKit/Source/core/css/RuleFeature.cpp - Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSURIValue.h ('K') | « third_party/WebKit/Source/core/css/FontFace.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSParserValues.h » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/RuleFeature.cpp

diff --git a/third_party/WebKit/Source/core/css/RuleFeature.cpp b/third_party/WebKit/Source/core/css/RuleFeature.cpp

index f89de00af3ef780abe8d90b3ac724873fc0d88cc..ceb30e9170f3a9151bb9db22aa2bfb1facfdc268 100644

--- a/third_party/WebKit/Source/core/css/RuleFeature.cpp

+++ b/third_party/WebKit/Source/core/css/RuleFeature.cpp

@@ -30,6 +30,7 @@

#include "core/css/RuleFeature.h"

#include "core/HTMLNames.h"

+#include "core/css/CSSCustomIdentValue.h"

#include "core/css/CSSFunctionValue.h"

#include "core/css/CSSSelector.h"

#include "core/css/CSSSelectorList.h"

@@ -318,7 +319,7 @@ void RuleFeatureSet::updateInvalidationSetsForContentAttribute(const RuleData& r

CSSFunctionValue* functionValue = toCSSFunctionValue(item.get());

if (functionValue->functionType() != CSSValueAttr)

continue;

- ensureAttributeInvalidationSet(AtomicString(toCSSPrimitiveValue(functionValue->item(0))->getStringValue())).setInvalidatesSelf();

+ ensureAttributeInvalidationSet(AtomicString(toCSSCustomIdentValue(functionValue->item(0))->value())).setInvalidatesSelf();

}