third_party/WebKit/Source/core/css/CSSCalculationValue.cpp - Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/css/CSSCounterValue.h » ('j') | third_party/WebKit/Source/core/css/CSSStringValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp b/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

index 0f78c2caf47a63cfb55b1731fec02b039b17c549..0eafcbd555c6fc9845d2927df8dec2c35e512658 100644

--- a/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp

@@ -120,9 +120,6 @@ static bool hasDoubleValue(CSSPrimitiveValue::UnitType type)

case CSSPrimitiveValue::UnitType::Integer:

return true;

case CSSPrimitiveValue::UnitType::Unknown:

- case CSSPrimitiveValue::UnitType::CustomIdentifier:

- case CSSPrimitiveValue::UnitType::String:

- case CSSPrimitiveValue::UnitType::URI:

case CSSPrimitiveValue::UnitType::RGBColor:

case CSSPrimitiveValue::UnitType::Calc:

case CSSPrimitiveValue::UnitType::CalcPercentageWithNumber: