Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: Source/core/css/CSSValue.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSValue.cpp
diff --git a/Source/core/css/CSSValue.cpp b/Source/core/css/CSSValue.cpp
index d2c3068f33667a4cda71329837fd4dfdef05e8af..bef285d02b12eb425ec2cd3762e875ebd335c975 100644
--- a/Source/core/css/CSSValue.cpp
+++ b/Source/core/css/CSSValue.cpp
@@ -50,6 +50,7 @@
#include "core/css/CSSReflectValue.h"
#include "core/css/CSSSVGDocumentValue.h"
#include "core/css/CSSShadowValue.h"
+#include "core/css/CSSStringValue.h"
#include "core/css/CSSTimingFunctionValue.h"
#include "core/css/CSSUnicodeRangeValue.h"
#include "core/css/CSSUnsetValue.h"
@@ -137,6 +138,8 @@ bool CSSValue::equals(const CSSValue& other) const
return compareCSSValues<CSSReflectValue>(*this, other);
case ShadowClass:
return compareCSSValues<CSSShadowValue>(*this, other);
+ case StringClass:
+ return compareCSSValues<CSSStringValue>(*this, other);
case CubicBezierTimingFunctionClass:
return compareCSSValues<CSSCubicBezierTimingFunctionValue>(*this, other);
case StepsTimingFunctionClass:
@@ -207,6 +210,8 @@ String CSSValue::cssText() const
return toCSSReflectValue(this)->customCSSText();
case ShadowClass:
return toCSSShadowValue(this)->customCSSText();
+ case StringClass:
+ return toCSSStringValue(this)->customCSSText();
case CubicBezierTimingFunctionClass:
return toCSSCubicBezierTimingFunctionValue(this)->customCSSText();
case StepsTimingFunctionClass:
@@ -296,6 +301,9 @@ void CSSValue::destroy()
case ShadowClass:
delete toCSSShadowValue(this);
return;
+ case StringClass:
+ delete toCSSStringValue(this);
+ return;
case CubicBezierTimingFunctionClass:
delete toCSSCubicBezierTimingFunctionValue(this);
return;
@@ -393,6 +401,9 @@ void CSSValue::finalizeGarbageCollectedObject()
case ShadowClass:
toCSSShadowValue(this)->~CSSShadowValue();
return;
+ case StringClass:
+ toCSSStringValue(this)->~CSSStringValue();
+ return;
case CubicBezierTimingFunctionClass:
toCSSCubicBezierTimingFunctionValue(this)->~CSSCubicBezierTimingFunctionValue();
return;
@@ -490,6 +501,9 @@ DEFINE_TRACE(CSSValue)
case ShadowClass:
toCSSShadowValue(this)->traceAfterDispatch(visitor);
return;
+ case StringClass:
+ toCSSStringValue(this)->traceAfterDispatch(visitor);
+ return;
case CubicBezierTimingFunctionClass:
toCSSCubicBezierTimingFunctionValue(this)->traceAfterDispatch(visitor);
return;

Powered by Google App Engine
This is Rietveld 408576698