Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values
Patch Set: Fixing tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/CSSToStyleMap.cpp
diff --git a/Source/core/css/resolver/CSSToStyleMap.cpp b/Source/core/css/resolver/CSSToStyleMap.cpp
index 4b6cae74de52dccf06e8c844e8d384739bfbcbaa..f0ac5560074e13fb2751e0db3105046f763d5429 100644
--- a/Source/core/css/resolver/CSSToStyleMap.cpp
+++ b/Source/core/css/resolver/CSSToStyleMap.cpp
@@ -347,10 +347,9 @@ AtomicString CSSToStyleMap::mapAnimationName(CSSValue* value)
{
if (value->isInitialValue())
return CSSAnimationData::initialName();
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- if (primitiveValue->getValueID() == CSSValueNone)
+ if (value->isPrimitiveValue() && toCSSPrimitiveValue(value)->getValueID() == CSSValueNone)
return CSSAnimationData::initialName();
- return AtomicString(primitiveValue->getStringValue());
+ return AtomicString(toCSSCustomIdentValue(value)->value());
}
EAnimPlayState CSSToStyleMap::mapAnimationPlayState(CSSValue* value)
@@ -367,9 +366,9 @@ CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSVal
{
if (value->isInitialValue())
return CSSTransitionData::initialProperty();
+ if (value->isCustomIdentValue())
+ return CSSTransitionData::TransitionProperty(toCSSCustomIdentValue(value)->value());
CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- if (primitiveValue->isCustomIdent())
- return CSSTransitionData::TransitionProperty(primitiveValue->getStringValue());
if (primitiveValue->getValueID() == CSSValueNone)
return CSSTransitionData::TransitionProperty(CSSTransitionData::TransitionNone);
return CSSTransitionData::TransitionProperty(primitiveValue->getPropertyID());

Powered by Google App Engine
This is Rietveld 408576698