Source/core/css/RuleFeature.cpp - Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/RuleFeature.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values

Patch Set: Fixing tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSStringValueBase.h ('K') | « Source/core/css/FontFace.cpp ('k') | Source/core/css/parser/CSSParserValues.h » ('j') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/RuleFeature.cpp

diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp

index d29f5b75ac7b860ef066bb81667b3a7b47b1cc79..5abd5f69be46d39511e14834f014d8bf7594369d 100644

--- a/Source/core/css/RuleFeature.cpp

+++ b/Source/core/css/RuleFeature.cpp

@@ -33,6 +33,7 @@

#include "core/css/CSSFunctionValue.h"

#include "core/css/CSSSelector.h"

#include "core/css/CSSSelectorList.h"

+#include "core/css/CSSStringValueBase.h"

#include "core/css/CSSValueList.h"

#include "core/css/RuleSet.h"

#include "core/css/StylePropertySet.h"

@@ -318,7 +319,7 @@ void RuleFeatureSet::updateInvalidationSetsForContentAttribute(const RuleData& r

CSSFunctionValue* functionValue = toCSSFunctionValue(item.get());

if (functionValue->functionType() != CSSValueAttr)

continue;

- ensureAttributeInvalidationSet(AtomicString(toCSSPrimitiveValue(functionValue->item(0))->getStringValue()));

+ ensureAttributeInvalidationSet(AtomicString(toCSSCustomIdentValue(functionValue->item(0))->value()));

}

« Source/core/css/CSSStringValueBase.h ('K') | « Source/core/css/FontFace.cpp ('k') | Source/core/css/parser/CSSParserValues.h » ('j') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')