Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Side by Side Diff: third_party/WebKit/Source/core/animation/DeferredLegacyStyleInterpolation.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/animation/DeferredLegacyStyleInterpolation.h" 6 #include "core/animation/DeferredLegacyStyleInterpolation.h"
7 7
8 #include "core/animation/ElementAnimations.h" 8 #include "core/animation/ElementAnimations.h"
9 #include "core/animation/css/CSSAnimatableValueFactory.h" 9 #include "core/animation/css/CSSAnimatableValueFactory.h"
10 #include "core/css/CSSBasicShapeValues.h" 10 #include "core/css/CSSBasicShapeValues.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 if (value.isCSSWideKeyword()) 49 if (value.isCSSWideKeyword())
50 return true; 50 return true;
51 if (value.isBasicShapeCircleValue()) 51 if (value.isBasicShapeCircleValue())
52 return interpolationRequiresStyleResolve(toCSSBasicShapeCircleValue(valu e)); 52 return interpolationRequiresStyleResolve(toCSSBasicShapeCircleValue(valu e));
53 if (value.isBasicShapeEllipseValue()) 53 if (value.isBasicShapeEllipseValue())
54 return interpolationRequiresStyleResolve(toCSSBasicShapeEllipseValue(val ue)); 54 return interpolationRequiresStyleResolve(toCSSBasicShapeEllipseValue(val ue));
55 if (value.isBasicShapePolygonValue()) 55 if (value.isBasicShapePolygonValue())
56 return interpolationRequiresStyleResolve(toCSSBasicShapePolygonValue(val ue)); 56 return interpolationRequiresStyleResolve(toCSSBasicShapePolygonValue(val ue));
57 if (value.isBasicShapeInsetValue()) 57 if (value.isBasicShapeInsetValue())
58 return interpolationRequiresStyleResolve(toCSSBasicShapeInsetValue(value )); 58 return interpolationRequiresStyleResolve(toCSSBasicShapeInsetValue(value ));
59 if (value.isStringValue() || value.isURIValue() || value.isCustomIdentValue( ))
60 return false;
59 if (value.isPrimitiveValue()) 61 if (value.isPrimitiveValue())
60 return interpolationRequiresStyleResolve(toCSSPrimitiveValue(value)); 62 return interpolationRequiresStyleResolve(toCSSPrimitiveValue(value));
61 if (value.isQuadValue()) 63 if (value.isQuadValue())
62 return interpolationRequiresStyleResolve(toCSSQuadValue(value)); 64 return interpolationRequiresStyleResolve(toCSSQuadValue(value));
63 if (value.isValueList()) 65 if (value.isValueList())
64 return interpolationRequiresStyleResolve(toCSSValueList(value)); 66 return interpolationRequiresStyleResolve(toCSSValueList(value));
65 if (value.isValuePair()) 67 if (value.isValuePair())
66 return interpolationRequiresStyleResolve(toCSSValuePair(value)); 68 return interpolationRequiresStyleResolve(toCSSValuePair(value));
67 if (value.isImageValue()) 69 if (value.isImageValue())
68 return interpolationRequiresStyleResolve(toCSSImageValue(value)); 70 return interpolationRequiresStyleResolve(toCSSImageValue(value));
69 if (value.isShadowValue()) 71 if (value.isShadowValue())
70 return interpolationRequiresStyleResolve(toCSSShadowValue(value)); 72 return interpolationRequiresStyleResolve(toCSSShadowValue(value));
71 if (value.isSVGDocumentValue()) 73 if (value.isSVGDocumentValue())
72 return interpolationRequiresStyleResolve(toCSSSVGDocumentValue(value)); 74 return interpolationRequiresStyleResolve(toCSSSVGDocumentValue(value));
73 // FIXME: consider other custom types. 75 // FIXME: consider other custom types.
74 return true; 76 return true;
75 } 77 }
76 78
77 bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C SSPrimitiveValue& primitiveValue) 79 bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C SSPrimitiveValue& primitiveValue)
78 { 80 {
79 // FIXME: consider other types. 81 // FIXME: consider other types.
80 if (primitiveValue.isNumber() || primitiveValue.isPercentage() || primitiveV alue.isAngle() || primitiveValue.isRGBColor() || primitiveValue.isURI()) 82 if (primitiveValue.isNumber() || primitiveValue.isPercentage() || primitiveV alue.isAngle() || primitiveValue.isRGBColor())
81 return false; 83 return false;
82 84
83 if (primitiveValue.isLength()) 85 if (primitiveValue.isLength())
84 return primitiveValue.isFontRelativeLength() || primitiveValue.isViewpor tPercentageLength(); 86 return primitiveValue.isFontRelativeLength() || primitiveValue.isViewpor tPercentageLength();
85 87
86 if (primitiveValue.isCalculated()) { 88 if (primitiveValue.isCalculated()) {
87 CSSLengthArray lengthArray(CSSPrimitiveValue::LengthUnitTypeCount); 89 CSSLengthArray lengthArray(CSSPrimitiveValue::LengthUnitTypeCount);
88 primitiveValue.accumulateLengthArray(lengthArray); 90 primitiveValue.accumulateLengthArray(lengthArray);
89 return lengthArray[CSSPrimitiveValue::UnitTypeFontSize] != 0 91 return lengthArray[CSSPrimitiveValue::UnitTypeFontSize] != 0
90 || lengthArray[CSSPrimitiveValue::UnitTypeFontXSize] != 0 92 || lengthArray[CSSPrimitiveValue::UnitTypeFontXSize] != 0
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 167
166 bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C SSQuadValue& quad) 168 bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C SSQuadValue& quad)
167 { 169 {
168 return interpolationRequiresStyleResolve(*quad.top()) 170 return interpolationRequiresStyleResolve(*quad.top())
169 || interpolationRequiresStyleResolve(*quad.right()) 171 || interpolationRequiresStyleResolve(*quad.right())
170 || interpolationRequiresStyleResolve(*quad.bottom()) 172 || interpolationRequiresStyleResolve(*quad.bottom())
171 || interpolationRequiresStyleResolve(*quad.left()); 173 || interpolationRequiresStyleResolve(*quad.left());
172 } 174 }
173 175
174 } 176 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698