Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: Source/core/css/resolver/StyleBuilderConverter.h

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * * Redistributions of source code must retain the above copyright 4 * * Redistributions of source code must retain the above copyright
5 * notice, this list of conditions and the following disclaimer. 5 * notice, this list of conditions and the following disclaimer.
6 * * Redistributions in binary form must reproduce the above 6 * * Redistributions in binary form must reproduce the above
7 * copyright notice, this list of conditions and the following disclaimer 7 * copyright notice, this list of conditions and the following disclaimer
8 * in the documentation and/or other materials provided with the 8 * in the documentation and/or other materials provided with the
9 * distribution. 9 * distribution.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
11 * contributors may be used to endorse or promote products derived from 11 * contributors may be used to endorse or promote products derived from
12 * this software without specific prior written permission. 12 * this software without specific prior written permission.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 14 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
15 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 15 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
16 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 16 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
17 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 17 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
18 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 18 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
19 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 19 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
20 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 20 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
21 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 21 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
22 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #ifndef StyleBuilderConverter_h 27 #ifndef StyleBuilderConverter_h
28 #define StyleBuilderConverter_h 28 #define StyleBuilderConverter_h
29 29
30 #include "core/css/CSSStringValue.h"
30 #include "core/css/CSSValue.h" 31 #include "core/css/CSSValue.h"
31 #include "core/css/CSSValueList.h" 32 #include "core/css/CSSValueList.h"
32 #include "core/css/resolver/StyleResolverState.h" 33 #include "core/css/resolver/StyleResolverState.h"
33 #include "core/layout/LayoutView.h" 34 #include "core/layout/LayoutView.h"
34 #include "core/style/QuotesData.h" 35 #include "core/style/QuotesData.h"
35 #include "core/style/ShadowList.h" 36 #include "core/style/ShadowList.h"
36 #include "core/style/StyleReflection.h" 37 #include "core/style/StyleReflection.h"
37 #include "core/style/StyleScrollSnapData.h" 38 #include "core/style/StyleScrollSnapData.h"
38 #include "core/style/TransformOrigin.h" 39 #include "core/style/TransformOrigin.h"
39 #include "platform/LengthSize.h" 40 #include "platform/LengthSize.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 } 148 }
148 return result; 149 return result;
149 } 150 }
150 ASSERT_NOT_REACHED(); 151 ASSERT_NOT_REACHED();
151 return 0; 152 return 0;
152 } 153 }
153 154
154 template <CSSValueID IdForNone> 155 template <CSSValueID IdForNone>
155 AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue* value) 156 AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue* value)
156 { 157 {
157 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value); 158 if (value->isPrimitiveValue() && toCSSPrimitiveValue(value)->getValueID() == IdForNone)
158 if (primitiveValue->getValueID() == IdForNone)
159 return nullAtom; 159 return nullAtom;
160 ASSERT(primitiveValue->isString()); 160 if (value->isStringValue() && toCSSStringValue(value)->serializationType() = = CSSStringValue::SerializeAsString)
161 return AtomicString(primitiveValue->getStringValue()); 161 return AtomicString(toCSSStringValue(value)->getStringValue());
162 ASSERT_NOT_REACHED();
163 return nullAtom;
162 } 164 }
163 165
164 } // namespace blink 166 } // namespace blink
165 167
166 #endif 168 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698