Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value); 342 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
343 if (primitiveValue->getValueID() == CSSValueInfinite) 343 if (primitiveValue->getValueID() == CSSValueInfinite)
344 return std::numeric_limits<double>::infinity(); 344 return std::numeric_limits<double>::infinity();
345 return primitiveValue->getFloatValue(); 345 return primitiveValue->getFloatValue();
346 } 346 }
347 347
348 AtomicString CSSToStyleMap::mapAnimationName(CSSValue* value) 348 AtomicString CSSToStyleMap::mapAnimationName(CSSValue* value)
349 { 349 {
350 if (value->isInitialValue()) 350 if (value->isInitialValue())
351 return CSSAnimationData::initialName(); 351 return CSSAnimationData::initialName();
352 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value); 352 if (value->isPrimitiveValue() && toCSSPrimitiveValue(value)->getValueID() == CSSValueNone)
353 if (primitiveValue->getValueID() == CSSValueNone)
354 return CSSAnimationData::initialName(); 353 return CSSAnimationData::initialName();
355 return AtomicString(primitiveValue->getStringValue()); 354 return AtomicString(toCSSStringValue(value)->getStringValue());
356 } 355 }
357 356
358 EAnimPlayState CSSToStyleMap::mapAnimationPlayState(CSSValue* value) 357 EAnimPlayState CSSToStyleMap::mapAnimationPlayState(CSSValue* value)
359 { 358 {
360 if (value->isInitialValue()) 359 if (value->isInitialValue())
361 return CSSAnimationData::initialPlayState(); 360 return CSSAnimationData::initialPlayState();
362 if (toCSSPrimitiveValue(value)->getValueID() == CSSValuePaused) 361 if (toCSSPrimitiveValue(value)->getValueID() == CSSValuePaused)
363 return AnimPlayStatePaused; 362 return AnimPlayStatePaused;
364 ASSERT(toCSSPrimitiveValue(value)->getValueID() == CSSValueRunning); 363 ASSERT(toCSSPrimitiveValue(value)->getValueID() == CSSValueRunning);
365 return AnimPlayStatePlaying; 364 return AnimPlayStatePlaying;
366 } 365 }
367 366
368 CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSVal ue* value) 367 CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSVal ue* value)
369 { 368 {
370 if (value->isInitialValue()) 369 if (value->isInitialValue())
371 return CSSTransitionData::initialProperty(); 370 return CSSTransitionData::initialProperty();
371 if (value->isStringValue() && toCSSStringValue(value)->serializationType() = = CSSStringValue::SerializeAsCustomIdentifier)
372 return CSSTransitionData::TransitionProperty(toCSSStringValue(value)->ge tStringValue());
372 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value); 373 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
373 if (primitiveValue->isCustomIdent())
374 return CSSTransitionData::TransitionProperty(primitiveValue->getStringVa lue());
375 if (primitiveValue->getValueID() == CSSValueNone) 374 if (primitiveValue->getValueID() == CSSValueNone)
376 return CSSTransitionData::TransitionProperty(CSSTransitionData::Transiti onNone); 375 return CSSTransitionData::TransitionProperty(CSSTransitionData::Transiti onNone);
377 return CSSTransitionData::TransitionProperty(primitiveValue->getPropertyID() ); 376 return CSSTransitionData::TransitionProperty(primitiveValue->getPropertyID() );
378 } 377 }
379 378
380 PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(CSSValue* v alue, bool allowStepMiddle) 379 PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(CSSValue* v alue, bool allowStepMiddle)
381 { 380 {
382 // FIXME: We should probably only call into this function with a valid 381 // FIXME: We should probably only call into this function with a valid
383 // single timing function value which isn't initial or inherit. We can 382 // single timing function value which isn't initial or inherit. We can
384 // currently get into here with initial since the parser expands unset 383 // currently get into here with initial since the parser expands unset
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 verticalRule = SpaceImageRule; 584 verticalRule = SpaceImageRule;
586 break; 585 break;
587 default: // CSSValueRepeat 586 default: // CSSValueRepeat
588 verticalRule = RepeatImageRule; 587 verticalRule = RepeatImageRule;
589 break; 588 break;
590 } 589 }
591 image.setVerticalRule(verticalRule); 590 image.setVerticalRule(verticalRule);
592 } 591 }
593 592
594 }; 593 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698